Re: [PATCH v5 11/13] media: hantro: Introduce G2/HEVC decoder

From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v5 11/13] media: hantro: Introduce G2/HEVC decoder
Date: Thu, 18 Mar 2021 03:28:09 +0800	[thread overview]
Message-ID: <202103180345.v5GE3usc-lkp@intel.com> (raw)
In-Reply-To: <20210317173202.107519-12-benjamin.gaignard@collabora.com>

[-- Attachment #1: Type: text/plain, Size: 2563 bytes --]

Hi Benjamin,

I love your patch! Perhaps something to improve:

[auto build test WARNING on sunxi/sunxi/for-next]
[also build test WARNING on robh/for-next v5.12-rc3 next-20210317]
[cannot apply to linuxtv-media/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Benjamin-Gaignard/Add-HANTRO-G2-HEVC-decoder-support-for-IMX8MQ/20210318-013515
base:   https://git.kernel.org/pub/scm/linux/kernel/git/sunxi/linux.git sunxi/for-next
config: nios2-allyesconfig (attached as .config)
compiler: nios2-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/92ff85add6e176c236b18f2a6a3e86468e5fb849
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Benjamin-Gaignard/Add-HANTRO-G2-HEVC-decoder-support-for-IMX8MQ/20210318-013515
        git checkout 92ff85add6e176c236b18f2a6a3e86468e5fb849
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=nios2 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/staging/media/hantro/hantro_g2_hevc_dec.c:520:6: warning: no previous prototype for 'hantro_g2_check_idle' [-Wmissing-prototypes]
     520 | void hantro_g2_check_idle(struct hantro_dev *vpu)
         |      ^~~~~~~~~~~~~~~~~~~~

vim +/hantro_g2_check_idle +520 drivers/staging/media/hantro/hantro_g2_hevc_dec.c

   519	
 > 520	void hantro_g2_check_idle(struct hantro_dev *vpu)
   521	{
   522		int i;
   523	
   524		for (i = 0; i < 3; i++) {
   525			u32 status;
   526	
   527			/* Make sure the VPU is idle */
   528			status = vdpu_read(vpu, HEVC_REG_INTERRUPT);
   529			if (status & HEVC_REG_INTERRUPT_DEC_E) {
   530				dev_warn(vpu->dev, "device still running, aborting");
   531				status |= HEVC_REG_INTERRUPT_DEC_ABORT_E | HEVC_REG_INTERRUPT_DEC_IRQ_DIS;
   532				vdpu_write(vpu, status, HEVC_REG_INTERRUPT);
   533			}
   534		}
   535	}
   536	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 58972 bytes --]