From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/2] xfs: move the xfs_can_free_eofblocks call under the IOLOCK
Date: Thu, 18 Mar 2021 23:01:10 -0700 [thread overview]
Message-ID: <20210319060110.GE1670408@magnolia> (raw)
In-Reply-To: <20210319055340.GA955126@infradead.org>
On Fri, Mar 19, 2021 at 05:53:40AM +0000, Christoph Hellwig wrote:
> On Thu, Mar 18, 2021 at 03:33:32PM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <djwong@kernel.org>
> >
> > In xfs_inode_free_eofblocks, move the xfs_can_free_eofblocks call
> > further down in the function to the point where we have taken the
> > IOLOCK. This is preparation for the next patch, where we will need that
> > lock (or equivalent) so that we can check if there are any post-eof
> > blocks to clean out.
> >
> > Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> > ---
> > fs/xfs/xfs_icache.c | 12 ++++--------
> > 1 file changed, 4 insertions(+), 8 deletions(-)
> >
> >
> > diff --git a/fs/xfs/xfs_icache.c b/fs/xfs/xfs_icache.c
> > index e6a62f765422..7353c9fe05db 100644
> > --- a/fs/xfs/xfs_icache.c
> > +++ b/fs/xfs/xfs_icache.c
> > @@ -1294,13 +1294,6 @@ xfs_inode_free_eofblocks(
> > if (!xfs_iflags_test(ip, XFS_IEOFBLOCKS))
> > return 0;
> >
> > - if (!xfs_can_free_eofblocks(ip, false)) {
> > - /* inode could be preallocated or append-only */
> > - trace_xfs_inode_free_eofblocks_invalid(ip);
> > - xfs_inode_clear_eofblocks_tag(ip);
> > - return 0;
> > - }
> > -
> > /*
> > * If the mapping is dirty the operation can block and wait for some
> > * time. Unless we are waiting, skip it.
> > @@ -1322,7 +1315,10 @@ xfs_inode_free_eofblocks(
> > }
> > *lockflags |= XFS_IOLOCK_EXCL;
> >
> > - return xfs_free_eofblocks(ip);
> > + if (xfs_can_free_eofblocks(ip, false))
> > + return xfs_free_eofblocks(ip);
>
> Don't we still need to clear the radix tree tag here?
I don't think so, because xfs_free_eofblocks will call
xfs_inode_clear_eofblocks_tag if it succeeds in freeing anything.
Though perhaps you're correct that we need to clear the tag if
!xfs_can_free_eofblocks, since we could have been called if
XFS_ICI_BLOCKGC_TAG was set in the radix tree because we once had a
posteof block but now we really only have cow blocks.
Yeah, ok, I'll add that back...
> Also the fs_inode_free_eofblocks_inval tracepoint is unused now.
...along with the tracepoint.
--D
next prev parent reply other threads:[~2021-03-19 6:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 22:33 [PATCHSET 0/2] xfs: make xfs_can_free_eofblocks a predicate Darrick J. Wong
2021-03-18 22:33 ` [PATCH 1/2] xfs: move the xfs_can_free_eofblocks call under the IOLOCK Darrick J. Wong
2021-03-19 5:53 ` Christoph Hellwig
2021-03-19 6:01 ` Darrick J. Wong [this message]
2021-03-19 6:31 ` Christoph Hellwig
2021-03-18 22:33 ` [PATCH 2/2] xfs: move the check for post-EOF mappings into xfs_can_free_eofblocks Darrick J. Wong
2021-03-19 5:59 ` Christoph Hellwig
2021-03-19 6:05 ` Darrick J. Wong
2021-03-19 6:35 ` Christoph Hellwig
2021-03-19 16:59 ` Darrick J. Wong
2021-03-23 18:32 ` Christoph Hellwig
2021-03-26 0:20 [PATCHSET v2 0/2] xfs: make xfs_can_free_eofblocks a predicate Darrick J. Wong
2021-03-26 0:21 ` [PATCH 1/2] xfs: move the xfs_can_free_eofblocks call under the IOLOCK Darrick J. Wong
2021-03-26 5:59 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210319060110.GE1670408@magnolia \
--to=djwong@kernel.org \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.