All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: alsa-devel@alsa-project.org
Cc: tiwai@suse.de, Libin Yang <libin.yang@intel.com>,
	broonie@kernel.org,
	Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Subject: [PATCH 7/8] ASoC: SOF: Intel: APL: set shutdown callback to hda_dsp_shutdown
Date: Mon, 22 Mar 2021 11:37:27 -0500	[thread overview]
Message-ID: <20210322163728.16616-8-pierre-louis.bossart@linux.intel.com> (raw)
In-Reply-To: <20210322163728.16616-1-pierre-louis.bossart@linux.intel.com>

From: Libin Yang <libin.yang@intel.com>

According to hardware spec and PMC FW requirement, the DSP must be
in D3 state before entering S5. Set shutdown call to hda_dsp_shutdown.

Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Signed-off-by: Libin Yang <libin.yang@intel.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
 sound/soc/sof/intel/apl.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/sound/soc/sof/intel/apl.c b/sound/soc/sof/intel/apl.c
index fc29b91b8932..c7ed2b3d6abc 100644
--- a/sound/soc/sof/intel/apl.c
+++ b/sound/soc/sof/intel/apl.c
@@ -27,9 +27,10 @@ static const struct snd_sof_debugfs_map apl_dsp_debugfs[] = {
 
 /* apollolake ops */
 const struct snd_sof_dsp_ops sof_apl_ops = {
-	/* probe and remove */
+	/* probe/remove/shutdown */
 	.probe		= hda_dsp_probe,
 	.remove		= hda_dsp_remove,
+	.shutdown	= hda_dsp_shutdown,
 
 	/* Register IO */
 	.write		= sof_io_write,
-- 
2.25.1


  parent reply	other threads:[~2021-03-22 16:41 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-22 16:37 [PATCH 0/8] ASoC: SOF: Intel: shutdown and core handling corrections Pierre-Louis Bossart
2021-03-22 16:37 ` [PATCH 1/8] ASoC: SOF: Intel: HDA: fix core status verification Pierre-Louis Bossart
2021-03-22 16:37 ` [PATCH 2/8] ASoC: SOF: core: harden shutdown helper Pierre-Louis Bossart
2021-03-22 16:37 ` [PATCH 3/8] ASoC: SOF: Intel: TGL: fix EHL ops Pierre-Louis Bossart
2021-03-22 16:37 ` [PATCH 4/8] ASoC: SOF: Intel: TGL: set shutdown callback to hda_dsp_shutdown Pierre-Louis Bossart
2021-03-22 16:37 ` [PATCH 5/8] ASoC: SOF: Intel: ICL: " Pierre-Louis Bossart
2021-03-22 16:37 ` [PATCH 6/8] ASoC: SOF: Intel: CNL: " Pierre-Louis Bossart
2021-03-22 16:37 ` Pierre-Louis Bossart [this message]
2021-03-22 16:37 ` [PATCH 8/8] ASoC: SOF: Intel: move ELH chip info Pierre-Louis Bossart
2021-03-23 22:12 ` [PATCH 0/8] ASoC: SOF: Intel: shutdown and core handling corrections Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210322163728.16616-8-pierre-louis.bossart@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=libin.yang@intel.com \
    --cc=ranjani.sridharan@linux.intel.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.