All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: "Kasireddy, Vivek" <vivek.kasireddy@intel.com>
Cc: "Zhang, Tina" <tina.zhang@intel.com>,
	"Marc-André Lureau" <marcandre.lureau@gmail.com>,
	QEMU <qemu-devel@nongnu.org>,
	"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH 00/15] virtio-gpu: split into two devices.
Date: Tue, 23 Mar 2021 09:18:42 +0100	[thread overview]
Message-ID: <20210323081842.yifdhyu4smznleqd@sirius.home.kraxel.org> (raw)
In-Reply-To: <7bce08a87c9c4deeb511f555ed835c49@intel.com>

On Mon, Mar 22, 2021 at 06:41:47PM +0000, Kasireddy, Vivek wrote:
> Hi Gerd,
> 
> > On Fri, Mar 19, 2021 at 03:48:42PM +0400, Marc-André Lureau wrote:
> > > Hi Gerd
> > >
> > > On Fri, Mar 19, 2021 at 3:22 PM Gerd Hoffmann <kraxel@redhat.com> wrote:
> > >
> > > > Currently we have one virtio-gpu device.  Problem with this approach is
> > > > that if you compile a full-featured qemu you'll get a virtio-gpu device
> > > > which depends on opengl and virgl, so these dependencies must be
> > > > installed and the libraries will be loaded into memory even if you don't
> > > > use virgl.  Also the code is cluttered with #ifdefs and a bit messy.
> > > >
> > > > This patch series splits the virtio-gpu device into two:
> > > >
> > > >  (1) virtio-gpu-device becomes the non-virgl device, same as
> > > >      virtio-gpu-device,virgl=off today.
> > > >  (2) virtio-gpu-gl-device is the new virgl device, same as
> > > >      virtio-gpu-device,virgl=on today.
> > > >
> > > > When compiling qemu without virglrenderer support virtio-gpu-device
> > > > behavior doesn't change.
> [Kasireddy, Vivek] Just a random thought: if a user enables both these devices 
> either intentionally or accidentally, can they play nice with each other?

Yes, should work fine.

take care,
  Gerd



      reply	other threads:[~2021-03-23  8:20 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-19 11:21 [PATCH 00/15] virtio-gpu: split into two devices Gerd Hoffmann
2021-03-19 11:21 ` [PATCH 01/15] virtio-gpu: rename virgl source file Gerd Hoffmann
2021-03-19 11:21 ` [PATCH 02/15] virtio-gpu: add virtio-gpu-gl-device Gerd Hoffmann
2021-03-19 11:21 ` [PATCH 03/15] virtio-gpu: add virtio-gpu-gl-pci Gerd Hoffmann
2021-03-19 11:21 ` [PATCH 04/15] virtio-gpu: add virtio-vga-gl Gerd Hoffmann
2021-03-19 11:21 ` [PATCH 05/15] virtio-gpu: move virgl realize + properties Gerd Hoffmann
2021-03-19 11:21 ` [PATCH 06/15] virtio-gpu: move virgl reset Gerd Hoffmann
2021-03-19 11:21 ` [PATCH 07/15] virtio-gpu: use class function for ctrl queue handlers Gerd Hoffmann
2021-03-19 11:21 ` [PATCH 08/15] virtio-gpu: move virgl handle_ctrl Gerd Hoffmann
2021-03-19 11:21 ` [PATCH 09/15] virtio-gpu: move virgl gl_flushed Gerd Hoffmann
2021-03-19 11:21 ` [PATCH 10/15] virtio-gpu: move virgl process_cmd Gerd Hoffmann
2021-03-19 11:21 ` [PATCH 11/15] virtio-gpu: move update_cursor_data Gerd Hoffmann
2021-03-19 11:21 ` [PATCH 12/15] virtio-gpu: drop VIRGL() macro Gerd Hoffmann
2021-03-19 11:21 ` [PATCH 13/15] virtio-gpu: move virtio-gpu-gl-device to separate module Gerd Hoffmann
2021-03-19 11:21 ` [PATCH 14/15] virtio-gpu: drop use_virgl_renderer Gerd Hoffmann
2021-03-19 11:21 ` [PATCH 15/15] virtio-gpu: move fields to struct VirtIOGPUGL Gerd Hoffmann
2021-03-19 11:42 ` [PATCH 00/15] virtio-gpu: split into two devices no-reply
2021-03-19 11:48 ` Marc-André Lureau
2021-03-22  8:14   ` Gerd Hoffmann
2021-03-22 18:41     ` Kasireddy, Vivek
2021-03-23  8:18       ` Gerd Hoffmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210323081842.yifdhyu4smznleqd@sirius.home.kraxel.org \
    --to=kraxel@redhat.com \
    --cc=marcandre.lureau@gmail.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=tina.zhang@intel.com \
    --cc=vivek.kasireddy@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.