Re: [PATCH 1/2] iio: inv_mpu6050: Remove superfluous indio_dev->modes assignment

From: Jonathan Cameron <jic23@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Jean-Baptiste Maneyrol <jmaneyrol@invensense.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	linux-iio@vger.kernel.org
Subject: Re: [PATCH 1/2] iio: inv_mpu6050: Remove superfluous indio_dev->modes assignment
Date: Mon, 29 Mar 2021 13:35:46 +0100	[thread overview]
Message-ID: <20210329133546.4ac4eb3b@jic23-huawei> (raw)
In-Reply-To: <20210325131046.13383-1-lars@metafoo.de>

On Thu, 25 Mar 2021 14:10:45 +0100
Lars-Peter Clausen <lars@metafoo.de> wrote:

> The inv_mpu6050 driver manually assigns the indio_dev->modes property. But
> this is not necessary since it will be setup in iio_trigger_buffer_setup().
> 
> Remove the manual assignment.
> 
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Both applied to the togreg branch of iio.git and pushed out as testing fo the
autobuilders to poke at it.

Thanks,

Jonathan

> ---
>  drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
> index 453c51c79655..99ee0a218875 100644
> --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
> +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
> @@ -1591,7 +1591,6 @@ int inv_mpu_core_probe(struct regmap *regmap, int irq, const char *name,
>  	}
>  
>  	indio_dev->info = &mpu_info;
> -	indio_dev->modes = INDIO_BUFFER_TRIGGERED;
>  
>  	result = devm_iio_triggered_buffer_setup(dev, indio_dev,
>  						 iio_pollfunc_store_time,