From: David Sterba <dsterba@suse.cz>
To: Anand Jain <anandsuveer@gmail.com>
Cc: Qu Wenruo <wqu@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v3 01/13] btrfs: add sysfs interface for supported sectorsize
Date: Mon, 29 Mar 2021 20:20:31 +0200 [thread overview]
Message-ID: <20210329182031.GP7604@twin.jikos.cz> (raw)
In-Reply-To: <b1a7aaf1-80ea-afa6-5bc3-a348ee0149a2@oracle.com>
On Thu, Mar 25, 2021 at 10:41:43PM +0800, Anand Jain wrote:
> On 25/03/2021 15:14, Qu Wenruo wrote:
> > +static ssize_t supported_sectorsizes_show(struct kobject *kobj,
> > + struct kobj_attribute *a,
> > + char *buf)
> > +{
> > + ssize_t ret = 0;
> > +
> > + /* Only support sectorsize == PAGE_SIZE yet */
> > + ret += scnprintf(buf + ret, PAGE_SIZE - ret, "%lu\n",
> > + PAGE_SIZE);
> > + return ret;
> > +}
>
> ret can be removed completely here.
You mean to do 'return scnprintf(...)' ? For now it's just a single
value returned but with further support there will be a pattern like is
eg. in supported_checksums_show, so it's ok as a preparatory work.
next prev parent reply other threads:[~2021-03-29 18:23 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-25 7:14 [PATCH v3 00/13] btrfs: support read-write for subpage metadata Qu Wenruo
2021-03-25 7:14 ` [PATCH v3 01/13] btrfs: add sysfs interface for supported sectorsize Qu Wenruo
2021-03-25 14:41 ` Anand Jain
2021-03-29 18:20 ` David Sterba [this message]
2021-04-01 22:32 ` Anand Jain
2021-04-01 17:56 ` David Sterba
2021-03-25 7:14 ` [PATCH v3 02/13] btrfs: use min() to replace open-code in btrfs_invalidatepage() Qu Wenruo
2021-03-25 7:14 ` [PATCH v3 03/13] btrfs: remove unnecessary variable shadowing " Qu Wenruo
2021-03-25 7:14 ` [PATCH v3 04/13] btrfs: refactor how we iterate ordered extent " Qu Wenruo
2021-04-02 1:15 ` Anand Jain
2021-04-02 3:33 ` Qu Wenruo
2021-03-25 7:14 ` [PATCH v3 05/13] btrfs: introduce helpers for subpage dirty status Qu Wenruo
2021-04-01 18:11 ` David Sterba
2021-03-25 7:14 ` [PATCH v3 06/13] btrfs: introduce helpers for subpage writeback status Qu Wenruo
2021-03-25 7:14 ` [PATCH v3 07/13] btrfs: allow btree_set_page_dirty() to do more sanity check on subpage metadata Qu Wenruo
2021-03-25 7:14 ` [PATCH v3 08/13] btrfs: support subpage metadata csum calculation at write time Qu Wenruo
2021-03-25 7:14 ` [PATCH v3 09/13] btrfs: make alloc_extent_buffer() check subpage dirty bitmap Qu Wenruo
2021-03-25 7:14 ` [PATCH v3 10/13] btrfs: make the page uptodate assert to be subpage compatible Qu Wenruo
2021-03-25 7:14 ` [PATCH v3 11/13] btrfs: make set/clear_extent_buffer_dirty() " Qu Wenruo
2021-03-25 7:14 ` [PATCH v3 12/13] btrfs: make set_btree_ioerr() accept extent buffer and " Qu Wenruo
2021-03-25 7:14 ` [PATCH v3 13/13] btrfs: add subpage overview comments Qu Wenruo
2021-03-25 12:20 ` [PATCH v3 00/13] btrfs: support read-write for subpage metadata Neal Gompa
2021-03-25 13:16 ` Qu Wenruo
2021-03-28 20:02 ` Ritesh Harjani
2021-03-29 2:01 ` Qu Wenruo
2021-04-02 1:39 ` Anand Jain
2021-04-02 3:26 ` Qu Wenruo
2021-04-02 8:33 ` Ritesh Harjani
2021-04-02 8:36 ` Qu Wenruo
2021-04-02 8:46 ` Ritesh Harjani
2021-04-02 8:52 ` Qu Wenruo
2021-04-12 11:33 ` Qu Wenruo
2021-04-15 3:44 ` riteshh
2021-04-15 14:52 ` riteshh
2021-04-15 23:19 ` Qu Wenruo
2021-04-15 23:34 ` Qu Wenruo
2021-04-16 1:34 ` Qu Wenruo
2021-04-16 5:50 ` riteshh
2021-04-16 6:14 ` Qu Wenruo
2021-04-16 16:52 ` riteshh
2021-04-19 5:59 ` riteshh
2021-04-19 6:16 ` Qu Wenruo
2021-04-19 7:04 ` riteshh
2021-04-19 7:19 ` Qu Wenruo
2021-04-19 13:24 ` Qu Wenruo
2021-04-21 7:03 ` riteshh
2021-04-21 7:15 ` Qu Wenruo
2021-04-21 7:30 ` riteshh
2021-04-21 8:26 ` Qu Wenruo
2021-04-21 11:13 ` riteshh
2021-04-21 11:42 ` Qu Wenruo
2021-04-21 12:15 ` riteshh
2021-03-29 18:53 ` David Sterba
2021-04-01 5:36 ` Qu Wenruo
2021-04-01 17:55 ` David Sterba
2021-04-02 1:27 ` Anand Jain
2021-04-03 11:08 ` David Sterba
2021-04-05 6:14 ` Qu Wenruo
2021-04-06 2:31 ` Anand Jain
2021-04-06 19:20 ` David Sterba
2021-04-06 23:59 ` Qu Wenruo
2021-04-06 19:13 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210329182031.GP7604@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=anandsuveer@gmail.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.