From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [RFC PATCH hyperv-next] scsi: storvsc: Use blk_mq_unique_tag() to generate requestIDs
Date: Fri, 09 Apr 2021 05:36:09 +0800 [thread overview]
Message-ID: <202104090549.8PLNcSap-lkp@intel.com> (raw)
In-Reply-To: <20210408161315.341888-1-parri.andrea@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 4067 bytes --]
Hi "Andrea,
[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on next-20210408]
[cannot apply to linux/master mkp-scsi/for-next scsi/for-next linus/master v5.12-rc6 v5.12-rc5 v5.12-rc4 v5.12-rc6]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Andrea-Parri-Microsoft/scsi-storvsc-Use-blk_mq_unique_tag-to-generate-requestIDs/20210409-001531
base: 6145d80cfc62e3ed8f16ff584d6287e6d88b82b9
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/75b45c0a08dd77d31250946c4bf114965d9f1835
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Andrea-Parri-Microsoft/scsi-storvsc-Use-blk_mq_unique_tag-to-generate-requestIDs/20210409-001531
git checkout 75b45c0a08dd77d31250946c4bf114965d9f1835
# save the attached .config to linux build tree
make W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/scsi/storvsc_drv.c:691:5: warning: no previous prototype for 'storvsc_next_request_id' [-Wmissing-prototypes]
691 | u64 storvsc_next_request_id(struct vmbus_channel *channel, u64 rqst_addr)
| ^~~~~~~~~~~~~~~~~~~~~~~
>> drivers/scsi/storvsc_drv.c:715:5: warning: no previous prototype for 'storvsc_request_addr' [-Wmissing-prototypes]
715 | u64 storvsc_request_addr(struct vmbus_channel *channel, u64 rqst_id)
| ^~~~~~~~~~~~~~~~~~~~
vim +/storvsc_next_request_id +691 drivers/scsi/storvsc_drv.c
690
> 691 u64 storvsc_next_request_id(struct vmbus_channel *channel, u64 rqst_addr)
692 {
693 struct storvsc_cmd_request *request =
694 (struct storvsc_cmd_request *)(unsigned long)rqst_addr;
695 struct storvsc_device *stor_device;
696 struct hv_device *device;
697
698 device = (channel->primary_channel != NULL) ?
699 channel->primary_channel->device_obj : channel->device_obj;
700 if (device == NULL)
701 return VMBUS_RQST_ERROR;
702
703 stor_device = get_out_stor_device(device);
704 if (stor_device == NULL)
705 return VMBUS_RQST_ERROR;
706
707 if (request == &stor_device->init_request)
708 return VMBUS_RQST_INIT;
709 if (request == &stor_device->reset_request)
710 return VMBUS_RQST_RESET;
711
712 return blk_mq_unique_tag(request->cmd->request);
713 }
714
> 715 u64 storvsc_request_addr(struct vmbus_channel *channel, u64 rqst_id)
716 {
717 struct storvsc_cmd_request *request;
718 struct storvsc_device *stor_device;
719 struct hv_device *device;
720 struct Scsi_Host *shost;
721 struct scsi_cmnd *scmnd;
722
723 device = (channel->primary_channel != NULL) ?
724 channel->primary_channel->device_obj : channel->device_obj;
725 if (device == NULL)
726 return VMBUS_RQST_ERROR;
727
728 stor_device = get_out_stor_device(device);
729 if (stor_device == NULL)
730 return VMBUS_RQST_ERROR;
731
732 if (rqst_id == VMBUS_RQST_INIT)
733 return (unsigned long)&stor_device->init_request;
734 if (rqst_id == VMBUS_RQST_RESET)
735 return (unsigned long)&stor_device->reset_request;
736
737 shost = stor_device->host;
738
739 scmnd = scsi_host_find_tag(shost, rqst_id);
740 if (scmnd == NULL)
741 return VMBUS_RQST_ERROR;
742
743 request = (struct storvsc_cmd_request *)(unsigned long)scsi_cmd_priv(scmnd);
744 return (unsigned long)request;
745 }
746
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 65923 bytes --]
next prev parent reply other threads:[~2021-04-08 21:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 16:13 [RFC PATCH hyperv-next] scsi: storvsc: Use blk_mq_unique_tag() to generate requestIDs Andrea Parri (Microsoft)
2021-04-08 21:36 ` kernel test robot [this message]
2021-04-09 15:38 ` Michael Kelley
2021-04-12 20:29 ` Andrea Parri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202104090549.8PLNcSap-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.