Re: [PATCH v2 6/6] Documentation: connector: Add slow-charger-loop definition

From: Rob Herring <robh@kernel.org>
To: Badhri Jagan Sridharan <badhri@google.com>
Cc: Guenter Roeck <linux@roeck-us.net>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Adam Thomson <Adam.Thomson.Opensource@diasemi.com>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, Kyle Tso <kyletso@google.com>
Subject: Re: [PATCH v2 6/6] Documentation: connector: Add slow-charger-loop definition
Date: Fri, 9 Apr 2021 13:38:03 -0500	[thread overview]
Message-ID: <20210409183803.GA3928012@robh.at.kernel.org> (raw)
In-Reply-To: <20210407200723.1914388-6-badhri@google.com>

On Wed, Apr 07, 2021 at 01:07:23PM -0700, Badhri Jagan Sridharan wrote:
> To allow slow charger loops to comply to pSnkStby requirement,
> this patch introduces slow-charger-loop which when set makes
> the port request PD_P_SNK_STDBY_MW upon entering SNK_DISCOVERY
> (instead of 3A or the 1.5A during SNK_DISCOVERY) and the actual
> currrent limit after RX of PD_CTRL_PSRDY for PD link or during
> SNK_READY for non-pd link.

What are 'slow charger loops' and pSnkStby?

'dt-bindings: connector: ...' for the subject. Follow the pattern you 
see with 'git log --oneline' for a directory.

> 
> Signed-off-by: Badhri Jagan Sridharan <badhri@google.com>
> ---
>  .../devicetree/bindings/connector/usb-connector.yaml       | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/connector/usb-connector.yaml b/Documentation/devicetree/bindings/connector/usb-connector.yaml
> index b6daedd62516..09ad3ad983a6 100644
> --- a/Documentation/devicetree/bindings/connector/usb-connector.yaml
> +++ b/Documentation/devicetree/bindings/connector/usb-connector.yaml
> @@ -197,6 +197,13 @@ properties:
>      $ref: /schemas/types.yaml#/definitions/uint32
>      enum: [1, 2, 3]
>  
> +  slow-charger-loop:
> +    description: Allows slow charging loops to comply to pSnkStby. When set makes
> +      the port request pSnkStby(2.5W - 5V@500mA) upon entering SNK_DISCOVERY(instead
> +      of 3A or the 1.5A during SNK_DISCOVERY) and the actual currrent limit after
> +      reception of PS_Ready for PD link or during SNK_READY for non-pd link.
> +    type: boolean
> +
>  required:
>    - compatible
>  
> -- 
> 2.31.1.295.g9ea45b61b8-goog
> 