Re: [PATCH v3] ALSA: control: Add memory consumption limit to user controls

From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH v3] ALSA: control: Add memory consumption limit to user controls
Date: Sat, 10 Apr 2021 17:20:16 +0900	[thread overview]
Message-ID: <20210410082016.GA10316@workstation> (raw)
In-Reply-To: <s5hsg3z4ezl.wl-tiwai@suse.de>

On Fri, Apr 09, 2021 at 06:09:02PM +0200, Takashi Iwai wrote:
> On Fri, 09 Apr 2021 12:59:10 +0200,
> Takashi Iwai wrote:
> > 
> > On Fri, 09 Apr 2021 04:27:35 +0200,
> > Takashi Sakamoto wrote:
> > > 
> > > 4. Add `max_user_ctl_alloc_size` kobject attribute to the control device
> > > 
> > > In the patch, a new module parameter 'max_user_ctl_alloc_size' is added.
> > > In the item, I use the value of this parameter as initial value per
> > > control device. The value per control device can be changed via sysfs
> > > node.
> > > 
> > > The `max_user_ctl_alloc_size` is really the attribute of control device,
> > > so I think it acceptable. Additionally, 'curr_user_ctl_alloc_size' is
> > > also added so that userspace applications get current status.
> > 
> > So that's the primary purpose?  Then it makes sense, yeah.
> 
> You meant something like below, right?

If you were carefully reading my items in the order, you would have
realized that the patch includes problem to share attribute group
table between several modules...

Device attribute is one of userspace interface expected to be stable. I'd
like to avoid careless changes which our known developer tends to do.

Thanks

Takashi Sakamoto