From: Cornelia Huck <cohuck@redhat.com>
To: Ilya Leoshkevich <iii@linux.ibm.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Thomas Huth <thuth@redhat.com>,
David Hildenbrand <david@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
qemu-devel@nongnu.org, Max Filippov <jcmvbkbc@gmail.com>,
qemu-s390x@nongnu.org, qemu-arm@nongnu.org,
Paolo Bonzini <pbonzini@redhat.com>,
Christian Borntraeger <borntraeger@de.ibm.com>
Subject: Re: [PATCH v4 0/4] accel/tcg: Make sure that tb->size != 0 after translation
Date: Thu, 15 Apr 2021 17:39:00 +0200 [thread overview]
Message-ID: <20210415173900.7062f159.cohuck@redhat.com> (raw)
In-Reply-To: <20210415130305.28640-1-iii@linux.ibm.com>
On Thu, 15 Apr 2021 15:03:01 +0200
Ilya Leoshkevich <iii@linux.ibm.com> wrote:
> If arch-specific code generates a translation block of size 0,
> tb_gen_code() may generate a spurious exception.
>
> Fix s390x (patch 1), ARM (patch 2) and xtensa (patch 3) and add an
> assertion in order to catch such situations earlier (patch 4).
>
> v1: https://lists.nongnu.org/archive/html/qemu-devel/2021-04/msg02037.html
> v1 -> v2: Fix target/s390x instead of trying to tolerate tb->size == 0
> in tb_gen_code().
>
> v2: https://lists.nongnu.org/archive/html/qemu-devel/2021-04/msg02101.html
> v2 -> v3: Split the common code change into a separate patch, add the
> ARM patch in order to fix
> https://gitlab.com/cohuck/qemu/-/jobs/1178409450
>
> v3: https://lists.nongnu.org/archive/html/qemu-devel/2021-04/msg02332.html
> v3 -> v4: Add the xtensa patch in order to fix
> https://gitlab.com/cohuck/qemu/-/jobs/1178409540
>
> Ilya Leoshkevich (4):
> target/s390x: Fix translation exception on illegal instruction
> target/arm: Make sure that commpage's tb->size != 0
> target/xtensa: Make sure that tb->size != 0
> accel/tcg: Assert that tb->size != 0 after translation
>
> accel/tcg/translate-all.c | 1 +
> target/arm/translate.c | 1 +
> target/s390x/translate.c | 16 +++++++++++-----
> target/xtensa/translate.c | 3 +++
> 4 files changed, 16 insertions(+), 5 deletions(-)
>
FWIW, this now has passed CI for me.
If all is good, who will merge it? I can merge through the s390x tree,
if I get acks on the patches for the other architectures, or I can give
my ack on the s390x patch, if somebody else is going to take it.
next prev parent reply other threads:[~2021-04-15 15:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-15 13:03 [PATCH v4 0/4] accel/tcg: Make sure that tb->size != 0 after translation Ilya Leoshkevich
2021-04-15 13:03 ` [PATCH v4 1/4] target/s390x: Fix translation exception on illegal instruction Ilya Leoshkevich
2021-04-15 13:03 ` [PATCH v4 2/4] target/arm: Make sure that commpage's tb->size != 0 Ilya Leoshkevich
2021-04-16 14:10 ` Peter Maydell
2021-04-16 15:38 ` Ilya Leoshkevich
2021-04-15 13:03 ` [PATCH v4 3/4] target/xtensa: Make sure that " Ilya Leoshkevich
2021-04-15 20:14 ` Max Filippov
2021-04-15 13:03 ` [PATCH v4 4/4] accel/tcg: Assert that tb->size != 0 after translation Ilya Leoshkevich
2021-04-15 15:39 ` Cornelia Huck [this message]
2021-04-16 11:53 ` [PATCH v4 0/4] accel/tcg: Make sure " Ilya Leoshkevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210415173900.7062f159.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=david@redhat.com \
--cc=iii@linux.ibm.com \
--cc=jcmvbkbc@gmail.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.