From: Bart Van Assche <bvanassche@acm.org>
To: "Martin K . Petersen" <martin.petersen@oracle.com>,
"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>
Cc: linux-scsi@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Bart Van Assche <bvanassche@acm.org>,
Mike Christie <michael.christie@oracle.com>
Subject: [PATCH v2 17/20] target: Compare explicitly with SAM_STAT_GOOD
Date: Thu, 15 Apr 2021 15:08:23 -0700 [thread overview]
Message-ID: <20210415220826.29438-18-bvanassche@acm.org> (raw)
In-Reply-To: <20210415220826.29438-1-bvanassche@acm.org>
Instead of leaving it implicit that SAM_STAT_GOOD == 0, compare explicitly
with SAM_STAT_GOOD.
Reviewed-by: Mike Christie <michael.christie@oracle.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
drivers/target/target_core_pscsi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/target/target_core_pscsi.c b/drivers/target/target_core_pscsi.c
index 1c9aeab93477..dac44caf77a3 100644
--- a/drivers/target/target_core_pscsi.c
+++ b/drivers/target/target_core_pscsi.c
@@ -1046,7 +1046,7 @@ static void pscsi_req_done(struct request *req, blk_status_t status)
int result = scsi_req(req)->result;
u8 scsi_status = status_byte(result) << 1;
- if (scsi_status) {
+ if (scsi_status != SAM_STAT_GOOD) {
pr_debug("PSCSI Status Byte exception at cmd: %p CDB:"
" 0x%02x Result: 0x%08x\n", cmd, pt->pscsi_cdb[0],
result);
next prev parent reply other threads:[~2021-04-15 22:08 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-15 22:08 [PATCH v2 00/20] SCSI patches for kernel v5.13 Bart Van Assche
2021-04-15 22:08 ` [PATCH v2 01/20] Make the scsi_alloc_sgtables() documentation more accurate Bart Van Assche
2021-04-15 22:08 ` [PATCH v2 02/20] Remove an incorrect comment Bart Van Assche
2021-04-15 22:08 ` [PATCH v2 03/20] Rename scsi_softirq_done() into scsi_complete() Bart Van Assche
2021-04-15 22:08 ` [PATCH v2 04/20] Modify the scsi_send_eh_cmnd() return value for the SDEV_BLOCK case Bart Van Assche
2021-04-15 22:08 ` [PATCH v2 05/20] Introduce enum scsi_disposition Bart Van Assche
2021-04-15 22:08 ` [PATCH v2 06/20] aacraid: Remove an unused function Bart Van Assche
2021-04-15 22:08 ` [PATCH v2 07/20] libfc: Fix a format specifier Bart Van Assche
2021-04-15 22:08 ` [PATCH v2 08/20] fcoe: Suppress a compiler warning Bart Van Assche
2021-04-15 22:08 ` [PATCH v2 09/20] mpt3sas: Fix two kernel-doc headers Bart Van Assche
2021-04-15 22:08 ` [PATCH v2 10/20] myrb: Remove unused functions Bart Van Assche
2021-04-15 22:08 ` [PATCH v2 11/20] myrs: " Bart Van Assche
2021-04-15 22:08 ` [PATCH v2 12/20] qla4xxx: Remove an unused function Bart Van Assche
2021-04-15 22:08 ` [PATCH v2 13/20] smartpqi: Remove unused functions Bart Van Assche
2021-04-15 22:08 ` [PATCH v2 14/20] 53c700: Open-code status_byte(u8) calls Bart Van Assche
2021-04-15 22:08 ` [PATCH v2 15/20] dc395x: " Bart Van Assche
2021-04-15 22:08 ` [PATCH v2 16/20] sd: Introduce a new local variable in sd_check_events() Bart Van Assche
2021-04-15 22:08 ` Bart Van Assche [this message]
2021-04-15 22:08 ` [PATCH v2 18/20] target: Fix two format specifiers Bart Van Assche
2021-04-15 23:31 ` Mike Christie
2021-04-15 22:08 ` [PATCH v2 19/20] target: Shorten ALUA error messages Bart Van Assche
2021-04-15 23:32 ` Mike Christie
2021-04-15 22:08 ` [PATCH v2 20/20] target/tcm_fc: Fix a kernel-doc header Bart Van Assche
2021-04-16 2:47 ` [PATCH v2 00/20] SCSI patches for kernel v5.13 Martin K. Petersen
2021-04-20 2:29 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210415220826.29438-18-bvanassche@acm.org \
--to=bvanassche@acm.org \
--cc=hch@lst.de \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=michael.christie@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.