From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: alsa-devel@alsa-project.org
Cc: tiwai@suse.de,
Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>,
Daniel Baluta <daniel.baluta@gmail.com>,
broonie@kernel.org,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Subject: [PATCH 5/5] ASoC: codecs: rt5682: clarify expression
Date: Fri, 16 Apr 2021 14:11:44 -0500 [thread overview]
Message-ID: <20210416191144.27006-6-pierre-louis.bossart@linux.intel.com> (raw)
In-Reply-To: <20210416191144.27006-1-pierre-louis.bossart@linux.intel.com>
cppcheck warning:
sound/soc/codecs/rt5682.c:2404:42: style: Boolean result is used in
bitwise operation. Clarify expression with
parentheses. [clarifyCondition]
(pll_code.m_bp << RT5682_PLL_M_BP_SFT | RT5682_PLL_RST));
^
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Daniel Baluta <daniel.baluta@gmail.com>
Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
---
sound/soc/codecs/rt5682.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/rt5682.c b/sound/soc/codecs/rt5682.c
index 0e2a10ed11da..a5aacfe01a0d 100644
--- a/sound/soc/codecs/rt5682.c
+++ b/sound/soc/codecs/rt5682.c
@@ -2401,7 +2401,7 @@ static int rt5682_set_component_pll(struct snd_soc_component *component,
(pll_code.n_code << RT5682_PLL_N_SFT) | pll_code.k_code);
snd_soc_component_write(component, RT5682_PLL_CTRL_2,
((pll_code.m_bp ? 0 : pll_code.m_code) << RT5682_PLL_M_SFT) |
- (pll_code.m_bp << RT5682_PLL_M_BP_SFT | RT5682_PLL_RST));
+ ((pll_code.m_bp << RT5682_PLL_M_BP_SFT) | RT5682_PLL_RST));
}
rt5682->pll_in[pll_id] = freq_in;
--
2.25.1
next prev parent reply other threads:[~2021-04-16 19:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-16 19:11 [PATCH 0/5] ASoC: remove more cppcheck warnings Pierre-Louis Bossart
2021-04-16 19:11 ` [PATCH 1/5] ASoC: soc-acpi: remove useless initialization Pierre-Louis Bossart
2021-04-16 19:11 ` [PATCH 2/5] ASoC: soc-core: fix signed/unsigned issue Pierre-Louis Bossart
2021-04-16 19:11 ` [PATCH 3/5] ASoC: soc-core: fix always-false condition Pierre-Louis Bossart
2021-04-16 19:11 ` [PATCH 4/5] ASoC: codecs: lpass-rx-macro: remove useless return Pierre-Louis Bossart
2021-04-16 19:11 ` Pierre-Louis Bossart [this message]
2021-04-19 17:33 ` [PATCH 0/5] ASoC: remove more cppcheck warnings Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210416191144.27006-6-pierre-louis.bossart@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=daniel.baluta@gmail.com \
--cc=guennadi.liakhovetski@linux.intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.