From: Kalle Valo <kvalo@codeaurora.org>
To: Lee Gibson <leegib@gmail.com>
Cc: imitsyanko@quantenna.com, davem@davemloft.net, kuba@kernel.org,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Lee Gibson <leegib@gmail.com>
Subject: Re: [PATCH] qtnfmac: Fix possible buffer overflow in qtnf_event_handle_external_auth
Date: Sat, 17 Apr 2021 17:24:16 +0000 (UTC) [thread overview]
Message-ID: <20210417172416.29509C433D3@smtp.codeaurora.org> (raw)
In-Reply-To: <20210317121706.389058-1-leegib@gmail.com>
Lee Gibson <leegib@gmail.com> wrote:
> Function qtnf_event_handle_external_auth calls memcpy without
> checking the length.
> A user could control that length and trigger a buffer overflow.
> Fix by checking the length is within the maximum allowed size.
>
> Signed-off-by: Lee Gibson <leegib@gmail.com>
Please use clamp_val() instead, that's preferred over min_t().
Patch set to Changes Requested.
--
https://patchwork.kernel.org/project/linux-wireless/patch/20210317121706.389058-1-leegib@gmail.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2021-04-17 17:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 12:17 [PATCH] qtnfmac: Fix possible buffer overflow in qtnf_event_handle_external_auth Lee Gibson
2021-04-17 17:24 ` Kalle Valo [this message]
2021-04-19 14:58 ` [PATCH v2] " Lee Gibson
2021-04-22 14:40 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210417172416.29509C433D3@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=davem@davemloft.net \
--cc=imitsyanko@quantenna.com \
--cc=kuba@kernel.org \
--cc=leegib@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.