From: David Ward <david.ward@gatech.edu>
To: Oder Chiou <oder_chiou@realtek.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>
Cc: Shuming Fan <shumingf@realtek.com>,
alsa-devel@alsa-project.org,
Bard Liao <yung-chuan.liao@linux.intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Mario Limonciello <mario_limonciello@dell.com>
Subject: [PATCH 4/5] ASoC: rt286: Make RT286_SET_GPIO_* readable and writable
Date: Sun, 18 Apr 2021 09:46:57 -0400 [thread overview]
Message-ID: <20210418134658.4333-5-david.ward@gatech.edu> (raw)
In-Reply-To: <20210418134658.4333-1-david.ward@gatech.edu>
The GPIO configuration cannot be applied if the registers are inaccessible.
This prevented the headset mic from working on the Dell XPS 13 9343.
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=114171
Signed-off-by: David Ward <david.ward@gatech.edu>
---
sound/soc/codecs/rt286.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/sound/soc/codecs/rt286.c b/sound/soc/codecs/rt286.c
index 67a5affdb705..45e4a48ef5bf 100644
--- a/sound/soc/codecs/rt286.c
+++ b/sound/soc/codecs/rt286.c
@@ -171,6 +171,9 @@ static bool rt286_readable_register(struct device *dev, unsigned int reg)
case RT286_PROC_COEF:
case RT286_SET_AMP_GAIN_ADC_IN1:
case RT286_SET_AMP_GAIN_ADC_IN2:
+ case RT286_SET_GPIO_MASK:
+ case RT286_SET_GPIO_DIRECTION:
+ case RT286_SET_GPIO_DATA:
case RT286_SET_POWER(RT286_DAC_OUT1):
case RT286_SET_POWER(RT286_DAC_OUT2):
case RT286_SET_POWER(RT286_ADC_IN1):
--
2.31.1
next prev parent reply other threads:[~2021-04-18 13:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-18 13:46 [PATCH 0/5] ASoC: rt286/rt298: Fixes for DMIC2 config and combo jack David Ward
2021-04-18 13:46 ` [PATCH 1/5] ASoC: rt286: Fix upper byte in DMIC2 configuration David Ward
2021-04-18 13:46 ` [PATCH 2/5] ASoC: rt286: Configure combo jack for headphones David Ward
2021-04-18 13:46 ` [PATCH 3/5] ASoC: rt298: " David Ward
2021-04-18 13:46 ` David Ward [this message]
2021-04-18 13:46 ` [PATCH 5/5] ASoC: rt286: Generalize support for ALC3263 codec David Ward
2021-04-19 14:54 ` [PATCH 0/5] ASoC: rt286/rt298: Fixes for DMIC2 config and combo jack Pierre-Louis Bossart
2021-04-19 17:33 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210418134658.4333-5-david.ward@gatech.edu \
--to=david.ward@gatech.edu \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=mario_limonciello@dell.com \
--cc=oder_chiou@realtek.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=shumingf@realtek.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.