From: David Miller <davem@davemloft.net>
To: aford173@gmail.com
Cc: netdev@vger.kernel.org, aford@beaconembedded.com,
geert@linux-m68k.org, sergei.shtylyov@gmail.com, kuba@kernel.org,
andrew@lunn.ch, linux-renesas-soc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: ethernet: ravb: Fix release of refclk
Date: Mon, 19 Apr 2021 15:45:45 -0700 (PDT) [thread overview]
Message-ID: <20210419.154545.1437529237095871426.davem@davemloft.net> (raw)
In-Reply-To: <20210417132329.6886-1-aford173@gmail.com>
From: Adam Ford <aford173@gmail.com>
Date: Sat, 17 Apr 2021 08:23:29 -0500
> The call to clk_disable_unprepare() can happen before priv is
> initialized. This means moving clk_disable_unprepare out of
> out_release into a new label.
>
> Fixes: 8ef7adc6beb2("net: ethernet: ravb: Enable optional refclk")
> Signed-off-by: Adam Ford <aford173@gmail.com>
Thjis does not apply cleanly, please rebbase and resubmit.
Please fix the formatting of your Fixes tag while you are at it, thank you.
next prev parent reply other threads:[~2021-04-19 22:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-17 13:23 [PATCH] net: ethernet: ravb: Fix release of refclk Adam Ford
2021-04-19 8:02 ` Geert Uytterhoeven
2021-04-19 9:38 ` Sergei Shtylyov
2021-04-19 22:45 ` David Miller [this message]
2021-04-20 3:33 ` Adam Ford
2021-04-21 14:05 Adam Ford
2021-04-21 14:25 ` Sergei Shtylyov
2021-04-21 16:03 ` Adam Ford
2021-04-21 18:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210419.154545.1437529237095871426.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=aford173@gmail.com \
--cc=aford@beaconembedded.com \
--cc=andrew@lunn.ch \
--cc=geert@linux-m68k.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.