All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: [PATCH] drm: bridge: fix odd_ptr_err.cocci warnings
Date: Mon, 19 Apr 2021 21:30:06 +0800	[thread overview]
Message-ID: <20210419133006.GA85881@111d09dd0559> (raw)
In-Reply-To: <20210419071223.2673533-3-narmstrong@baylibre.com>

[-- Attachment #1: Type: text/plain, Size: 1242 bytes --]

From: kernel test robot <lkp@intel.com>

drivers/gpu/drm/bridge/ite-it66121.c:944:5-11: inconsistent IS_ERR and PTR_ERR on line 946.

 PTR_ERR should access the value just tested by IS_ERR

Semantic patch information:
 There can be false positives in the patch case, where it is the call to
 IS_ERR that is wrong.

Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci

CC: Phong LE <ple@baylibre.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

url:    https://github.com/0day-ci/linux/commits/Neil-Armstrong/drm-bridge-Add-it66121-driver/20210419-151301
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git bf05bf16c76bb44ab5156223e1e58e26dfe30a88

 ite-it66121.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/gpu/drm/bridge/ite-it66121.c
+++ b/drivers/gpu/drm/bridge/ite-it66121.c
@@ -943,7 +943,7 @@ static int it66121_probe(struct i2c_clie
 	ctx->regmap = devm_regmap_init_i2c(client, &it66121_regmap_config);
 	if (IS_ERR(ctx->regmap)) {
 		ite66121_power_off(ctx);
-		return PTR_ERR(ctx);
+		return PTR_ERR(ctx->regmap);
 	}
 
 	regmap_read(ctx->regmap, IT66121_VENDOR_ID0_REG, &vendor_ids[0]);

  parent reply	other threads:[~2021-04-19 13:30 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-19  7:12 [PATCH v4 0/3] drm/bridge: Add it66121 driver Neil Armstrong
2021-04-19  7:12 ` Neil Armstrong
2021-04-19  7:12 ` [PATCH v4 1/3] dt-bindings: display: bridge: add it66121 bindings Neil Armstrong
2021-04-19  7:12   ` Neil Armstrong
2021-04-19  7:12 ` [PATCH v4 2/3] drm: bridge: add it66121 driver Neil Armstrong
2021-04-19  7:12   ` Neil Armstrong
2021-04-19  9:44   ` Robert Foss
2021-04-19  9:44     ` Robert Foss
2021-04-19 13:30   ` kernel test robot [this message]
2021-04-21  9:25   ` Neil Armstrong
2021-04-21  9:25     ` Neil Armstrong
2021-04-21  9:58     ` Paul Cercueil
2021-04-21  9:58       ` Paul Cercueil
2021-04-21 11:50       ` Neil Armstrong
2021-04-21 11:50         ` Neil Armstrong
2021-04-19  7:12 ` [PATCH v4 3/3] MAINTAINERS: add it66121 HDMI bridge driver entry Neil Armstrong
2021-04-19  7:12   ` Neil Armstrong
2021-04-21 11:55 ` [PATCH v4 0/3] drm/bridge: Add it66121 driver Neil Armstrong
2021-04-21 11:55   ` Neil Armstrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210419133006.GA85881@111d09dd0559 \
    --to=lkp@intel.com \
    --cc=kbuild-all@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.