From: Jason Gunthorpe <jgg@nvidia.com>
To: Shiraz Saleem <shiraz.saleem@intel.com>
Cc: dledford@redhat.com, linux-rdma@vger.kernel.org,
Sindhu Devale <sindhu.devale@intel.com>,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH] i40iw: Fix error unwinding when i40iw_hmc_sd_one fails
Date: Tue, 20 Apr 2021 16:10:06 -0300 [thread overview]
Message-ID: <20210420191006.GC2185150@nvidia.com> (raw)
In-Reply-To: <20210416002104.323-1-shiraz.saleem@intel.com>
On Thu, Apr 15, 2021 at 07:21:04PM -0500, Shiraz Saleem wrote:
> From: Sindhu Devale <sindhu.devale@intel.com>
>
> When i40iw_hmc_sd_one fails, chunk is freed without the
> deletion of chunk entry in the PBLE info list.
>
> Fix it by adding the chunk entry to the PBLE info list only
> after successful addition of SD in i40iw_hmc_sd_one.
>
> This fixes a static checker warning reported in [1]
>
> [1] https://lore.kernel.org/linux-rdma/YHV4CFXzqTm23AOZ@mwanda/
>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Sindhu Devale <sindhu.devale@intel.com>
> Signed-off-by: Shiraz Saleem <shiraz.saleem@intel.com>
> ---
> drivers/infiniband/hw/i40iw/i40iw_pble.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
I added a fixes line an applied to for-next, thanks
Jason
prev parent reply other threads:[~2021-04-20 19:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-16 0:21 [PATCH] i40iw: Fix error unwinding when i40iw_hmc_sd_one fails Shiraz Saleem
2021-04-20 19:10 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210420191006.GC2185150@nvidia.com \
--to=jgg@nvidia.com \
--cc=dan.carpenter@oracle.com \
--cc=dledford@redhat.com \
--cc=linux-rdma@vger.kernel.org \
--cc=shiraz.saleem@intel.com \
--cc=sindhu.devale@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.