From: Borislav Petkov <bp@alien8.de>
To: Naoya Horiguchi <nao.horiguchi@gmail.com>
Cc: linux-mm@kvack.org, Tony Luck <tony.luck@intel.com>,
Aili Yao <yaoaili@kingsoft.com>,
Andrew Morton <akpm@linux-foundation.org>,
Oscar Salvador <osalvador@suse.de>,
David Hildenbrand <david@redhat.com>,
Andy Lutomirski <luto@kernel.org>,
Naoya Horiguchi <naoya.horiguchi@nec.com>,
Jue Wang <juew@google.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/3] mm,hwpoison: add kill_accessing_process() to find error virtual address
Date: Thu, 22 Apr 2021 19:02:13 +0200 [thread overview]
Message-ID: <20210422170213.GE7021@zn.tnic> (raw)
In-Reply-To: <20210421005728.1994268-4-nao.horiguchi@gmail.com>
On Wed, Apr 21, 2021 at 09:57:28AM +0900, Naoya Horiguchi wrote:
> From: Naoya Horiguchi <naoya.horiguchi@nec.com>
>
> The previous patch solves the infinite MCE loop issue when multiple
"previous patch" has no meaning when it is in git.
> MCE events races. The remaining issue is to make sure that all threads
"race."
> processing Action Required MCEs send to the current processes the
s/the //
> SIGBUS with the proper virtual address and the error size.
>
> This patch suggests to do page table walk to find the error virtual
Avoid having "This patch" or "This commit" in the commit message. It is
tautologically useless.
Also, do
$ git grep 'This patch' Documentation/process
for more details.
> address. If we find multiple virtual addresses in walking, we now can't
Who's "we"? during the pagetable walk
> determine which one is correct, so we fall back to sending SIGBUS in
> kill_me_maybe() without error info as we do now. This corner case needs
> to be solved in the future.
Solved how? If you can't map which error comes from which process, you
can't do anything here. You could send SIGBUS to all but you might
injure some innocent bystanders this way.
Just code structuring suggestions below - mm stuff is for someone else
to review properly.
> +static int hwpoison_pte_range(pmd_t *pmdp, unsigned long addr,
> + unsigned long end, struct mm_walk *walk)
> +{
> + struct hwp_walk *hwp = (struct hwp_walk *)walk->private;
> + int ret = 0;
> + pte_t *ptep;
> + spinlock_t *ptl;
> +
> + ptl = pmd_trans_huge_lock(pmdp, walk->vma);
> + if (ptl) {
Save yourself an indentation level:
if (!ptl)
goto unlock;
> + pmd_t pmd = *pmdp;
> +
> + if (pmd_present(pmd)) {
... ditto...
> + unsigned long pfn = pmd_pfn(pmd);
> +
> + if (pfn <= hwp->pfn && hwp->pfn < pfn + HPAGE_PMD_NR) {
> + unsigned long hwpoison_vaddr = addr +
> + ((hwp->pfn - pfn) << PAGE_SHIFT);
... which will allow you to not break those.
> +
> + ret = set_to_kill(&hwp->tk, hwpoison_vaddr,
> + PAGE_SHIFT);
> + }
> + }
> + spin_unlock(ptl);
> + goto out;
> + }
> +
> + if (pmd_trans_unstable(pmdp))
> + goto out;
> +
> + ptep = pte_offset_map_lock(walk->vma->vm_mm, pmdp, addr, &ptl);
> + for (; addr != end; ptep++, addr += PAGE_SIZE) {
> + ret = check_hwpoisoned_entry(*ptep, addr, PAGE_SHIFT,
> + hwp->pfn, &hwp->tk);
> + if (ret == 1)
> + break;
> + }
> + pte_unmap_unlock(ptep - 1, ptl);
> +out:
> + cond_resched();
> + return ret;
> +}
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2021-04-22 17:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-21 0:57 [PATCH v3 0/3] mm,hwpoison: fix sending SIGBUS for Action Required MCE Naoya Horiguchi
2021-04-21 0:57 ` [PATCH v3 1/3] mm/memory-failure: Use a mutex to avoid memory_failure() races Naoya Horiguchi
2021-04-22 17:01 ` Borislav Petkov
2021-04-21 0:57 ` [PATCH v3 2/3] mm,hwpoison: return -EHWPOISON when page already Naoya Horiguchi
2021-04-22 17:02 ` Borislav Petkov
2021-04-23 2:17 ` HORIGUCHI NAOYA(堀口 直也)
2021-04-21 0:57 ` [PATCH v3 3/3] mm,hwpoison: add kill_accessing_process() to find error virtual address Naoya Horiguchi
2021-04-22 17:02 ` Borislav Petkov [this message]
2021-04-23 2:18 ` HORIGUCHI NAOYA(堀口 直也)
2021-04-23 11:57 ` Borislav Petkov
2021-04-26 8:23 ` HORIGUCHI NAOYA(堀口 直也)
2021-05-07 2:10 ` [PATCH v3 0/3] mm,hwpoison: fix sending SIGBUS for Action Required MCE Luck, Tony
2021-05-07 3:37 ` Luck, Tony
2021-05-07 5:24 ` HORIGUCHI NAOYA(堀口 直也)
2021-05-07 11:14 ` Aili Yao
2021-05-07 18:02 ` Luck, Tony
2021-05-08 2:38 ` Aili Yao
2021-05-10 3:28 ` Luck, Tony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210422170213.GE7021@zn.tnic \
--to=bp@alien8.de \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=juew@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=nao.horiguchi@gmail.com \
--cc=naoya.horiguchi@nec.com \
--cc=osalvador@suse.de \
--cc=tony.luck@intel.com \
--cc=yaoaili@kingsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.