From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: Re: [PATCH 06/78] media: renesas-ceu: fix pm_runtime_get_sync() usage count
Date: Sun, 25 Apr 2021 06:51:17 +0800 [thread overview]
Message-ID: <202104250630.qQzvcn7v-lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 3326 bytes --]
CC: kbuild-all(a)lists.01.org
In-Reply-To: <29ba3fafde4d2643fae49789e6b378d6b1fd51f5.1619191723.git.mchehab+huawei@kernel.org>
References: <29ba3fafde4d2643fae49789e6b378d6b1fd51f5.1619191723.git.mchehab+huawei@kernel.org>
TO: Mauro Carvalho Chehab <mchehab@kernel.org>
CC: linux-media(a)vger.kernel.org
CC: linuxarm(a)huawei.com
CC: mauro.chehab(a)huawei.com
CC: Mauro Carvalho Chehab <mchehab@kernel.org>
CC: linux-media(a)vger.kernel.org
CC: Jacopo Mondi <jacopo@jmondi.org>
CC: linux-kernel(a)vger.kernel.org
CC: linux-renesas-soc(a)vger.kernel.org
Hi Mauro,
I love your patch! Perhaps something to improve:
[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on rockchip/for-next tegra/for-next v5.12-rc8 next-20210423]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Mauro-Carvalho-Chehab/media-use-pm_runtime_resume_and_get-instead-of-pm_runtime_get_sync/20210424-145029
base: git://linuxtv.org/media_tree.git master
:::::: branch date: 16 hours ago
:::::: commit date: 16 hours ago
config: riscv-allyesconfig (attached as .config)
compiler: riscv64-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>
cocci warnings: (new ones prefixed by >>)
>> drivers/media/platform/renesas-ceu.c:1104:2-8: preceding lock on line 1100
vim +1104 drivers/media/platform/renesas-ceu.c
32e5a70dc8f4e9 Jacopo Mondi 2018-02-22 1090
32e5a70dc8f4e9 Jacopo Mondi 2018-02-22 1091 static int ceu_open(struct file *file)
32e5a70dc8f4e9 Jacopo Mondi 2018-02-22 1092 {
32e5a70dc8f4e9 Jacopo Mondi 2018-02-22 1093 struct ceu_device *ceudev = video_drvdata(file);
32e5a70dc8f4e9 Jacopo Mondi 2018-02-22 1094 int ret;
32e5a70dc8f4e9 Jacopo Mondi 2018-02-22 1095
32e5a70dc8f4e9 Jacopo Mondi 2018-02-22 1096 ret = v4l2_fh_open(file);
32e5a70dc8f4e9 Jacopo Mondi 2018-02-22 1097 if (ret)
32e5a70dc8f4e9 Jacopo Mondi 2018-02-22 1098 return ret;
32e5a70dc8f4e9 Jacopo Mondi 2018-02-22 1099
32e5a70dc8f4e9 Jacopo Mondi 2018-02-22 @1100 mutex_lock(&ceudev->mlock);
32e5a70dc8f4e9 Jacopo Mondi 2018-02-22 1101 /* Causes soft-reset and sensor power on on first open */
4825ba42eb8d20 Mauro Carvalho Chehab 2021-04-24 1102 ret = pm_runtime_resume_and_get(ceudev->dev);
4825ba42eb8d20 Mauro Carvalho Chehab 2021-04-24 1103 if (ret < 0)
4825ba42eb8d20 Mauro Carvalho Chehab 2021-04-24 @1104 return ret;
4825ba42eb8d20 Mauro Carvalho Chehab 2021-04-24 1105
32e5a70dc8f4e9 Jacopo Mondi 2018-02-22 1106 mutex_unlock(&ceudev->mlock);
32e5a70dc8f4e9 Jacopo Mondi 2018-02-22 1107
32e5a70dc8f4e9 Jacopo Mondi 2018-02-22 1108 return 0;
32e5a70dc8f4e9 Jacopo Mondi 2018-02-22 1109 }
32e5a70dc8f4e9 Jacopo Mondi 2018-02-22 1110
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 68970 bytes --]
next reply other threads:[~2021-04-24 22:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-24 22:51 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-04-24 6:44 [PATCH 00/78] media: use pm_runtime_resume_and_get() instead of pm_runtime_get_sync() Mauro Carvalho Chehab
2021-04-24 6:44 ` [PATCH 06/78] media: renesas-ceu: fix pm_runtime_get_sync() usage count Mauro Carvalho Chehab
2021-04-24 8:11 ` Jacopo Mondi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202104250630.qQzvcn7v-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.