Re: [PATCH] quota: Use 'hlist_for_each_entry' to simplify code

From: Jan Kara <jack@suse.cz>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: jack@suse.com, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] quota: Use 'hlist_for_each_entry' to simplify code
Date: Wed, 28 Apr 2021 14:26:44 +0200	[thread overview]
Message-ID: <20210428122644.GD25222@quack2.suse.cz> (raw)
In-Reply-To: <f82d3e33964dcbd2aac19866735e0a8381c8a735.1619599407.git.christophe.jaillet@wanadoo.fr>

On Wed 28-04-21 10:44:19, Christophe JAILLET wrote:
> Use 'hlist_for_each_entry' instead of hand writing it.
> This saves a few lines of code.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> Compile tested only
> ---
>  fs/quota/dquot.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)

Thanks for the cleanup. It looks good.  I'll queue it to my tree after the
merge window closes (i.e., in about two weeks).

								Honza

> 
> diff --git a/fs/quota/dquot.c b/fs/quota/dquot.c
> index 4f1373463766..22d904bde6ab 100644
> --- a/fs/quota/dquot.c
> +++ b/fs/quota/dquot.c
> @@ -288,14 +288,12 @@ static inline void remove_dquot_hash(struct dquot *dquot)
>  static struct dquot *find_dquot(unsigned int hashent, struct super_block *sb,
>  				struct kqid qid)
>  {
> -	struct hlist_node *node;
>  	struct dquot *dquot;
>  
> -	hlist_for_each (node, dquot_hash+hashent) {
> -		dquot = hlist_entry(node, struct dquot, dq_hash);
> +	hlist_for_each_entry(dquot, dquot_hash+hashent, dq_hash)
>  		if (dquot->dq_sb == sb && qid_eq(dquot->dq_id, qid))
>  			return dquot;
> -	}
> +
>  	return NULL;
>  }
>  
> -- 
> 2.30.2
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR