From: Rob Herring <robh@kernel.org>
To: Shawn Guo <shawn.guo@linaro.org>
Cc: Stephen Boyd <sboyd@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Sivaprakash Murugesan <sivaprak@codeaurora.org>,
Benjamin Li <benl@squareup.com>,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-clk@vger.kernel.org
Subject: Re: [PATCH 2/5] dt-bindings: clock: update qcom,a53pll bindings for MSM8939 support
Date: Thu, 6 May 2021 15:27:26 -0500 [thread overview]
Message-ID: <20210506202726.GA744866@robh.at.kernel.org> (raw)
In-Reply-To: <20210504052844.21096-3-shawn.guo@linaro.org>
On Tue, May 04, 2021 at 01:28:41PM +0800, Shawn Guo wrote:
> Update qcom,a53pll bindings for MSM8939 support:
>
> - Add optional clock-output-names property.
> - Add MSM8939 specific compatibles.
> - Add MSM8939 examples.
>
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> ---
> .../bindings/clock/qcom,a53pll.yaml | 34 +++++++++++++++++++
> 1 file changed, 34 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/clock/qcom,a53pll.yaml b/Documentation/devicetree/bindings/clock/qcom,a53pll.yaml
> index db3d0ea6bc7a..7a410a76be2f 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,a53pll.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,a53pll.yaml
> @@ -18,6 +18,9 @@ properties:
> enum:
> - qcom,ipq6018-a53pll
> - qcom,msm8916-a53pll
> + - qcom,msm8939-a53pll-c0
> + - qcom,msm8939-a53pll-c1
> + - qcom,msm8939-a53pll-cci
These 3 have differences?
>
> reg:
> maxItems: 1
> @@ -33,6 +36,9 @@ properties:
> items:
> - const: xo
>
> + clock-output-names:
> + maxItems: 1
> +
> required:
> - compatible
> - reg
> @@ -57,3 +63,31 @@ examples:
> clocks = <&xo>;
> clock-names = "xo";
> };
> + #Example 3 - A53 PLLs found on MSM8939 devices
> + - |
> + a53pll_c1: clock-controller@b016000 {
> + compatible = "qcom,msm8939-a53pll-c1";
> + reg = <0xb016000 0x40>;
> + #clock-cells = <0>;
> + clocks = <&xo_board>;
> + clock-names = "xo";
> + clock-output-names = "a53pll_c1";
> + };
> +
> + a53pll_c0: clock-controller@b116000 {
> + compatible = "qcom,msm8939-a53pll-c0";
> + reg = <0xb116000 0x40>;
> + #clock-cells = <0>;
> + clocks = <&xo_board>;
> + clock-names = "xo";
> + clock-output-names = "a53pll_c0";
> + };
> +
> + a53pll_cci: clock-controller@b1d0000 {
> + compatible = "qcom,msm8939-a53pll-cci";
> + reg = <0xb1d0000 0x40>;
> + #clock-cells = <0>;
> + clocks = <&xo_board>;
> + clock-names = "xo";
> + clock-output-names = "a53pll_cci";
> + };
Do these examples really add anything?
next prev parent reply other threads:[~2021-05-06 20:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-04 5:28 [PATCH 0/5] Add MSM8939 APCS/A53PLL clock support Shawn Guo
2021-05-04 5:28 ` [PATCH 1/5] clk: qcom: apcs-msm8916: Flag a53mux instead of a53pll as critical Shawn Guo
2021-06-28 0:27 ` Stephen Boyd
2021-06-29 2:37 ` Shawn Guo
2021-05-04 5:28 ` [PATCH 2/5] dt-bindings: clock: update qcom,a53pll bindings for MSM8939 support Shawn Guo
2021-05-06 20:27 ` Rob Herring [this message]
2021-05-07 0:18 ` Shawn Guo
2021-05-04 5:28 ` [PATCH 3/5] clk: qcom: apcs-msm8916: Retrieve clock name from DT Shawn Guo
2021-06-28 0:28 ` Stephen Boyd
2021-06-29 13:36 ` Shawn Guo
2021-06-29 15:57 ` Bjorn Andersson
2021-06-29 20:23 ` Stephen Boyd
2021-06-29 20:39 ` Bjorn Andersson
2021-05-04 5:28 ` [PATCH 4/5] clk: qcom: a53-pll: Pass freq_tbl via match data Shawn Guo
2021-05-04 5:28 ` [PATCH 5/5] clk: qcom: a53-pll: Add MSM8939 a53pll clocks Shawn Guo
2021-06-28 0:24 ` Stephen Boyd
2021-06-21 6:37 ` [PATCH 0/5] Add MSM8939 APCS/A53PLL clock support Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210506202726.GA744866@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=benl@squareup.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=sboyd@kernel.org \
--cc=shawn.guo@linaro.org \
--cc=sivaprak@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.