From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Patrick Menschel <menschel.p@posteo.de>
Cc: Drew Fustini <drew@beagleboard.org>,
netdev@vger.kernel.org, linux-can@vger.kernel.org,
Will C <will@macchina.cc>
Subject: Re: [net-next 6/6] can: mcp251xfd: mcp251xfd_regmap_crc_read(): work around broken CRC on TBC register
Date: Mon, 10 May 2021 09:45:55 +0200 [thread overview]
Message-ID: <20210510074555.ufojb42u5cyrmomb@pengutronix.de> (raw)
In-Reply-To: <b58d4484-db27-f199-875e-ae3694cd271f@posteo.de>
[-- Attachment #1: Type: text/plain, Size: 1191 bytes --]
On 09.05.2021 07:46:20, Patrick Menschel wrote:
> > Do I have to change my test?
>
> I changed my test to 1 hour and removed the sleep statement.
> Still no measurable difference for performance and no CRC Errors with
> both kernels.
See other mail about my thoughts about performance and CRC.
> Apparently the test is hard on the CPU, I have two pytest processes
> listed in htop one with 80%CPU and one with 60% CPU, approx 30% ram
> usage of 512MB. I have no clue how it reaches the CPU values, there
> should be only one CPU on the pi0w.
Interesting :)
> ### 5.10.17+ on pi0w ###
>
> 2021-05-09 08:02:56 [ INFO] 725649 frames in 1:00:00
> (test_socketcan.py:890)
>
> ### 5.10.31-performance-backports+ on pi0w ###
>
> 2021-05-09 09:13:32 [ INFO] 715936 frames in 1:00:00
> (test_socketcan.py:890)
>
> I'll switch boards to a pi3b and test again with these settings.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-05-10 9:54 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 8:01 pull-request: can-next 2021-04-07 Marc Kleine-Budde
2021-04-07 8:01 ` [net-next 1/6] can: skb: alloc_can{,fd}_skb(): set "cf" to NULL if skb allocation fails Marc Kleine-Budde
2021-04-07 8:01 ` [net-next 2/6] can: m_can: m_can_receive_skb(): add missing error handling to can_rx_offload_queue_sorted() call Marc Kleine-Budde
2021-04-07 8:01 ` [net-next 3/6] can: c_can: remove unused enum BOSCH_C_CAN_PLATFORM Marc Kleine-Budde
2021-04-07 8:01 ` [net-next 4/6] can: mcp251xfd: add BQL support Marc Kleine-Budde
2021-04-07 8:01 ` [net-next 5/6] can: mcp251xfd: mcp251xfd_regmap_crc_read_one(): Factor out crc check into separate function Marc Kleine-Budde
2021-04-07 8:01 ` [net-next 6/6] can: mcp251xfd: mcp251xfd_regmap_crc_read(): work around broken CRC on TBC register Marc Kleine-Budde
2021-04-21 19:58 ` Drew Fustini
2021-04-22 7:18 ` Marc Kleine-Budde
2021-04-22 16:46 ` Patrick Menschel
2021-05-07 7:25 ` Marc Kleine-Budde
2021-05-07 8:21 ` Patrick Menschel
2021-05-07 8:25 ` Marc Kleine-Budde
2021-05-08 18:36 ` Patrick Menschel
2021-05-09 7:46 ` Patrick Menschel
2021-05-10 7:45 ` Marc Kleine-Budde [this message]
2021-05-20 10:29 ` Patrick Menschel
2021-05-10 7:43 ` Marc Kleine-Budde
2021-12-07 16:53 ` Modilaynen, Pavel
2021-12-08 8:54 ` Marc Kleine-Budde
2021-12-09 10:22 ` Thomas.Kopp
2021-12-09 11:17 ` AW: " Sven Schuchmann
2021-12-09 11:27 ` Marc Kleine-Budde
2021-12-09 12:53 ` AW: " Sven Schuchmann
2021-12-13 22:12 ` Modilaynen, Pavel
2021-12-21 22:24 ` Thomas.Kopp
2022-06-21 14:25 ` Marc Kleine-Budde
2022-06-22 8:19 ` Marc Kleine-Budde
2022-06-22 13:47 ` Thomas.Kopp
2022-06-26 19:14 ` Marc Kleine-Budde
2021-05-07 22:36 ` Drew Fustini
2021-05-08 12:30 ` Marc Kleine-Budde
2021-04-07 22:10 ` pull-request: can-next 2021-04-07 patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210510074555.ufojb42u5cyrmomb@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=drew@beagleboard.org \
--cc=linux-can@vger.kernel.org \
--cc=menschel.p@posteo.de \
--cc=netdev@vger.kernel.org \
--cc=will@macchina.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.