From: John Snow <jsnow@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>,
qemu-block@nongnu.org, Max Reitz <mreitz@redhat.com>,
Cleber Rosa <crosa@redhat.com>, John Snow <jsnow@redhat.com>
Subject: [PATCH 04/10] python/console_socket: Add a pylint ignore
Date: Wed, 12 May 2021 17:46:36 -0400 [thread overview]
Message-ID: <20210512214642.2803189-5-jsnow@redhat.com> (raw)
In-Reply-To: <20210512214642.2803189-1-jsnow@redhat.com>
We manage cleaning up this resource ourselves. Pylint should shush.
Signed-off-by: John Snow <jsnow@redhat.com>
---
python/qemu/console_socket.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/python/qemu/console_socket.py b/python/qemu/console_socket.py
index 87237bebef7..8c4ff598ad7 100644
--- a/python/qemu/console_socket.py
+++ b/python/qemu/console_socket.py
@@ -39,6 +39,7 @@ def __init__(self, address: str, file: Optional[str] = None,
self.connect(address)
self._logfile = None
if file:
+ # pylint: disable=consider-using-with
self._logfile = open(file, "bw")
self._open = True
self._drain_thread = None
--
2.30.2
next prev parent reply other threads:[~2021-05-12 21:48 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-12 21:46 [PATCH 00/10] Python: delint iotests, machine.py and console_socket.py John Snow
2021-05-12 21:46 ` [PATCH 01/10] python/console_socket: avoid one-letter variable John Snow
2021-05-13 9:39 ` Philippe Mathieu-Daudé
2021-05-12 21:46 ` [PATCH 02/10] python/machine: use subprocess.DEVNULL instead of open(os.path.devnull) John Snow
2021-05-13 9:39 ` Philippe Mathieu-Daudé
2021-05-12 21:46 ` [PATCH 03/10] python/machine: use subprocess.run instead of subprocess.Popen John Snow
2021-05-14 14:08 ` Wainer dos Santos Moschetta
2021-05-14 19:00 ` John Snow
2021-05-14 19:13 ` John Snow
2021-05-12 21:46 ` John Snow [this message]
2021-05-12 21:46 ` [PATCH 05/10] python/machine: Disable pylint warning for open() in _pre_launch John Snow
2021-05-14 14:42 ` Wainer dos Santos Moschetta
2021-05-14 19:03 ` John Snow
2021-05-12 21:46 ` [PATCH 06/10] python/machine: disable warning for Popen in _launch() John Snow
2021-05-12 21:46 ` [PATCH 07/10] iotests: use subprocess.run where possible John Snow
2021-05-14 19:22 ` John Snow
2021-05-12 21:46 ` [PATCH 08/10] iotests: use 'with open()' where applicable John Snow
2021-05-13 9:40 ` Philippe Mathieu-Daudé
2021-05-12 21:46 ` [PATCH 09/10] iotests: silence spurious consider-using-with warnings John Snow
2021-05-12 21:46 ` [PATCH 10/10] iotests: ensure that QemuIoInteractive definitely closes John Snow
2021-05-17 16:11 ` [PATCH 00/10] Python: delint iotests, machine.py and console_socket.py John Snow
2021-05-17 17:02 ` Emanuele Giuseppe Esposito
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210512214642.2803189-5-jsnow@redhat.com \
--to=jsnow@redhat.com \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.