From: Randy Dunlap <rdunlap@infradead.org>
To: linux-kernel@vger.kernel.org
Cc: Randy Dunlap <rdunlap@infradead.org>, Stefan Roese <sr@denx.de>,
Vinod Koul <vkoul@kernel.org>,
dmaengine@vger.kernel.org, Sinan Kaya <okaya@codeaurora.org>,
Green Wan <green.wan@sifive.com>,
Hyun Kwon <hyun.kwon@xilinx.com>,
Tejas Upadhyay <tejasu@xilinx.com>,
Michal Simek <michal.simek@xilinx.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
kernel test robot <lkp@intel.com>
Subject: [PATCH 2/4] DMA: QCOM_HIDMA_MGMT depends on HAS_IOMEM
Date: Fri, 21 May 2021 19:13:11 -0700 [thread overview]
Message-ID: <20210522021313.16405-3-rdunlap@infradead.org> (raw)
In-Reply-To: <20210522021313.16405-1-rdunlap@infradead.org>
When CONFIG_HAS_IOMEM is not set/enabled, certain iomap() family
functions [including ioremap(), devm_ioremap(), etc.] are not
available.
Drivers that use these functions should depend on HAS_IOMEM so that
they do not cause build errors.
Rectifies these build errors:
s390-linux-ld: drivers/dma/qcom/hidma_mgmt.o: in function `hidma_mgmt_probe':
hidma_mgmt.c:(.text+0x780): undefined reference to `devm_ioremap_resource'
s390-linux-ld: drivers/dma/qcom/hidma_mgmt.o: in function `hidma_mgmt_init':
hidma_mgmt.c:(.init.text+0x126): undefined reference to `of_address_to_resource'
s390-linux-ld: hidma_mgmt.c:(.init.text+0x16e): undefined reference to `of_address_to_resource'
Fixes: 67a2003e0607 ("dmaengine: add Qualcomm Technologies HIDMA channel driver")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: kernel test robot <lkp@intel.com>
Cc: Sinan Kaya <okaya@codeaurora.org>
Cc: Vinod Koul <vkoul@kernel.org>
Cc: dmaengine@vger.kernel.org
---
drivers/dma/qcom/Kconfig | 1 +
1 file changed, 1 insertion(+)
--- linux-next-20210521.orig/drivers/dma/qcom/Kconfig
+++ linux-next-20210521/drivers/dma/qcom/Kconfig
@@ -33,6 +33,7 @@ config QCOM_GPI_DMA
config QCOM_HIDMA_MGMT
tristate "Qualcomm Technologies HIDMA Management support"
+ depends on HAS_IOMEM
select DMA_ENGINE
help
Enable support for the Qualcomm Technologies HIDMA Management.
next prev parent reply other threads:[~2021-05-22 2:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-22 2:13 [PATCH 0/4] DMA: several drivers depend on HAS_IOMEM Randy Dunlap
2021-05-22 2:13 ` [PATCH 1/4] DMA: ALTERA_MSGDMA depends " Randy Dunlap
2021-05-22 7:21 ` Stefan Roese
2021-05-22 2:13 ` Randy Dunlap [this message]
2021-05-22 2:13 ` [PATCH 3/4] DMA: SF_PDMA " Randy Dunlap
2021-05-22 2:13 ` [PATCH 4/4] DMA: XILINX_ZYNQMP_DPDMA " Randy Dunlap
2021-05-23 0:20 ` Laurent Pinchart
2021-05-23 1:07 ` Randy Dunlap
2021-05-23 18:53 ` Laurent Pinchart
2021-05-23 19:08 ` Randy Dunlap
2021-05-31 4:12 ` Vinod Koul
2021-05-31 4:14 ` [PATCH 0/4] DMA: several drivers depend " Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210522021313.16405-3-rdunlap@infradead.org \
--to=rdunlap@infradead.org \
--cc=dmaengine@vger.kernel.org \
--cc=green.wan@sifive.com \
--cc=hyun.kwon@xilinx.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=michal.simek@xilinx.com \
--cc=okaya@codeaurora.org \
--cc=sr@denx.de \
--cc=tejasu@xilinx.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.