From: Alex Williamson <alex.williamson@redhat.com>
To: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: Cornelia Huck <cohuck@redhat.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hardening@vger.kernel.org
Subject: Re: [PATCH][next] vfio/iommu_type1: Use struct_size() for kzalloc()
Date: Mon, 24 May 2021 13:48:01 -0600 [thread overview]
Message-ID: <20210524134801.406bc4bf@x1.home.shazbot.org> (raw)
In-Reply-To: <20210513230155.GA217517@embeddedor>
On Thu, 13 May 2021 18:01:55 -0500
"Gustavo A. R. Silva" <gustavoars@kernel.org> wrote:
> Make use of the struct_size() helper instead of an open-coded version,
> in order to avoid any potential type mistakes or integer overflows
> that, in the worst scenario, could lead to heap overflows.
>
> This code was detected with the help of Coccinelle and, audited and
> fixed manually.
>
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> ---
> drivers/vfio/vfio_iommu_type1.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/vfio/vfio_iommu_type1.c b/drivers/vfio/vfio_iommu_type1.c
> index a0747c35a778..a3e925a41b0d 100644
> --- a/drivers/vfio/vfio_iommu_type1.c
> +++ b/drivers/vfio/vfio_iommu_type1.c
> @@ -2795,7 +2795,7 @@ static int vfio_iommu_iova_build_caps(struct vfio_iommu *iommu,
> return 0;
> }
>
> - size = sizeof(*cap_iovas) + (iovas * sizeof(*cap_iovas->iova_ranges));
> + size = struct_size(cap_iovas, iova_ranges, iovas);
>
> cap_iovas = kzalloc(size, GFP_KERNEL);
> if (!cap_iovas)
Looks good, applied to vfio for-linus branch for v5.13. Thanks,
Alex
next prev parent reply other threads:[~2021-05-24 19:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-13 23:01 [PATCH][next] vfio/iommu_type1: Use struct_size() for kzalloc() Gustavo A. R. Silva
2021-05-24 19:48 ` Alex Williamson [this message]
2021-05-24 19:59 ` Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210524134801.406bc4bf@x1.home.shazbot.org \
--to=alex.williamson@redhat.com \
--cc=cohuck@redhat.com \
--cc=gustavoars@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.