All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/net/sungem: Fix inconsistent indenting
Date: Wed, 26 May 2021 17:09:37 -0700	[thread overview]
Message-ID: <20210526170937.4228f917@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <1622024648-33438-1-git-send-email-jiapeng.chong@linux.alibaba.com>

On Wed, 26 May 2021 18:24:08 +0800 Jiapeng Chong wrote:
> Eliminate the follow smatch warning:
> 
> drivers/net/sungem_phy.c:412 genmii_read_link() warn: inconsistent
> indenting.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
>  drivers/net/sungem_phy.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/sungem_phy.c b/drivers/net/sungem_phy.c
> index 291fa44..4daac5f 100644
> --- a/drivers/net/sungem_phy.c
> +++ b/drivers/net/sungem_phy.c
> @@ -409,7 +409,7 @@ static int genmii_read_link(struct mii_phy *phy)
>  	 * though magic-aneg shouldn't prevent this case from occurring
>  	 */
>  
> -	 return 0;
> +	return 0;
>  }
>  
>  static int generic_suspend(struct mii_phy* phy)

Do you have any statistics on how many such patches we'd need to apply
to make the kernel free for such warning? If it's too many it's probably
not worth it, this patch for example has net zero effect on readability.

      reply	other threads:[~2021-05-27  0:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-26 10:24 [PATCH] drivers/net/sungem: Fix inconsistent indenting Jiapeng Chong
2021-05-27  0:09 ` Jakub Kicinski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210526170937.4228f917@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
    --to=kuba@kernel.org \
    --cc=davem@davemloft.net \
    --cc=jiapeng.chong@linux.alibaba.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.