Re: [PATCH V3 7/9] tracing: Add __print_ns_to_secs() and __print_ns_without_secs() helpers

From: Steven Rostedt <rostedt@goodmis.org>
To: Joe Perches <joe@perches.com>
Cc: Daniel Bristot de Oliveira <bristot@redhat.com>,
	linux-kernel@vger.kernel.org, Phil Auld <pauld@redhat.com>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Kate Carcia <kcarcia@redhat.com>,
	Jonathan Corbet <corbet@lwn.net>, Ingo Molnar <mingo@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Alexandre Chartre <alexandre.chartre@oracle.com>,
	Clark Willaims <williams@redhat.com>,
	John Kacur <jkacur@redhat.com>,
	Juri Lelli <juri.lelli@redhat.com>,
	linux-doc@vger.kernel.org
Subject: Re: [PATCH V3 7/9] tracing: Add __print_ns_to_secs() and __print_ns_without_secs() helpers
Date: Fri, 4 Jun 2021 12:21:28 -0400	[thread overview]
Message-ID: <20210604122128.0d348960@oasis.local.home> (raw)
In-Reply-To: <1e068d21106bb6db05b735b4916bb420e6c9842a.camel@perches.com>

On Thu, 03 Jun 2021 21:19:50 -0700
Joe Perches <joe@perches.com> wrote:

> If tracing cleanups for trace_events.h are being done, perhaps
> another bit of untidiness is the macro definition and uses of
> __assign_str.

This isn't a tracing cleanup, but adding new functionality.

That said,

> 
> $ git grep -w -1 __assign_str include/trace/trace_events.h
> include/trace/trace_events.h-
> include/trace/trace_events.h:#undef __assign_str
> include/trace/trace_events.h:#define __assign_str(dst, src)                                             \
> include/trace/trace_events.h-   strcpy(__get_str(dst), (src) ? (const char *)(src) : "(null)");
> 
> Its definition has a semicolon as do most uses but a dozen handfuls of
> other uses do not have a semicolon.  It'd be more consistent to add a
> semicolon to the uses without them and when done treewide, then remove
> the semicolon from the macro declaration.

I have no problem taking a clean up patch that adds semicolons to all
use cases of "__assign_str()" and ever remove the one from where it is
defined. As long as it doesn't break any builds, I'm fine with that.

-- Steve