From: Wenli Looi <wlooi@ucalgary.ca>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Cc: Wenli Looi <wlooi@ucalgary.ca>
Subject: [PATCH] staging: rtl8723bs: Fix uninitialized variable
Date: Sun, 6 Jun 2021 00:00:21 -0700 [thread overview]
Message-ID: <20210606070021.116284-1-wlooi@ucalgary.ca> (raw)
Uninitialized struct with invalid pointer causes BUG and prevents access
point from working. Access point works once I apply this patch.
https://forum.armbian.com/topic/14727-wifi-ap-kernel-bug-in-kernel-5444/
has more details.
Signed-off-by: Wenli Looi <wlooi@ucalgary.ca>
---
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
index 2fb80b6eb..7308e1185 100644
--- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
+++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
@@ -2384,7 +2384,7 @@ void rtw_cfg80211_indicate_sta_assoc(struct adapter *padapter, u8 *pmgmt_frame,
DBG_871X(FUNC_ADPT_FMT"\n", FUNC_ADPT_ARG(padapter));
{
- struct station_info sinfo;
+ struct station_info sinfo = {};
u8 ie_offset;
if (GetFrameSubType(pmgmt_frame) == WIFI_ASSOCREQ)
ie_offset = _ASOCREQ_IE_OFFSET_;
--
2.25.1
next reply other threads:[~2021-06-06 7:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-06 7:00 Wenli Looi [this message]
2021-06-06 7:13 ` [PATCH] staging: rtl8723bs: Fix uninitialized variable Greg Kroah-Hartman
2021-06-06 7:51 ` Wenli Looi
2021-06-06 8:00 ` Fabio M. De Francesco
2021-06-06 8:09 ` Wenli Looi
2021-06-06 8:09 ` Wenli Looi
2021-06-06 8:45 ` Fabio M. De Francesco
2021-06-06 18:46 ` [PATCH v2] " Wenli Looi
2021-06-07 8:35 ` Dan Carpenter
2021-06-07 8:46 ` Dan Carpenter
2021-06-08 6:35 ` Wenli Looi
2021-06-08 6:35 ` Wenli Looi
2021-06-07 8:33 ` [PATCH] " Dan Carpenter
2021-06-07 9:23 ` Greg Kroah-Hartman
2021-06-07 10:43 ` Dan Carpenter
2021-06-08 6:46 ` [PATCH] staging: rtl8723bs: Fix uninitialized variables Wenli Looi
2021-06-08 7:20 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210606070021.116284-1-wlooi@ucalgary.ca \
--to=wlooi@ucalgary.ca \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.