From: Jan Kara <jack@suse.cz>
To: Pavel Skripkin <paskripkin@gmail.com>
Cc: Jan Kara <jack@suse.cz>,
tiantao6@hisilicon.com, rdunlap@infradead.org,
reiserfs-devel@vger.kernel.org, linux-kernel@vger.kernel.org,
syzbot+0ba9909df31c6a36974d@syzkaller.appspotmail.com
Subject: Re: [PATCH v2] reiserfs: add check for invalid 1st journal block
Date: Tue, 8 Jun 2021 13:56:45 +0200 [thread overview]
Message-ID: <20210608115645.GF5562@quack2.suse.cz> (raw)
In-Reply-To: <20210608134443.022b3389@gmail.com>
On Tue 08-06-21 13:44:43, Pavel Skripkin wrote:
> On Mon, 17 May 2021 15:08:18 +0200
> Jan Kara <jack@suse.cz> wrote:
>
> > On Mon 17-05-21 15:15:45, Pavel Skripkin wrote:
> > > syzbot reported divide error in reiserfs.
> > > The problem was in incorrect journal 1st block.
> > >
> > > Syzbot's reproducer manualy generated wrong superblock
> > > with incorrect 1st block. In journal_init() wasn't
> > > any checks about this particular case.
> > >
> > > For example, if 1st journal block is before superblock
> > > 1st block, it can cause zeroing important superblock members
> > > in do_journal_end().
> > >
> > > Reported-by: syzbot+0ba9909df31c6a36974d@syzkaller.appspotmail.com
> > > Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
> >
> > Thanks! I've added the patch to my tree.
> >
> > Honza
> >
>
> Hi, Jan!
>
> Is this patched got lost somehow? I did't find it in your tree here
> https://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs.git/.
>
> Sorry to bother you, maybe Im missing something :)
It's sitting in my for_next branch as commit a149127be52f. I'll push it to
Linus in the coming merge window.
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
prev parent reply other threads:[~2021-06-08 11:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-14 21:23 [PATCH] reiserfs: add check for invalid 1st journal block Pavel Skripkin
2021-05-17 10:15 ` Jan Kara
2021-05-17 11:37 ` Pavel Skripkin
2021-05-17 12:15 ` [PATCH v2] " Pavel Skripkin
2021-05-17 13:08 ` Jan Kara
2021-06-08 10:44 ` Pavel Skripkin
2021-06-08 11:56 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210608115645.GF5562@quack2.suse.cz \
--to=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=paskripkin@gmail.com \
--cc=rdunlap@infradead.org \
--cc=reiserfs-devel@vger.kernel.org \
--cc=syzbot+0ba9909df31c6a36974d@syzkaller.appspotmail.com \
--cc=tiantao6@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.