Re: [PATCH v1 2/5] fpga: altera-pr-ip: Remove fpga_mgr_unregister() call

From: Xu Yilun <yilun.xu@intel.com>
To: Russ Weight <russell.h.weight@intel.com>
Cc: mdf@kernel.org, linux-fpga@vger.kernel.org, trix@redhat.com,
	lgoncalv@redhat.com, hao.wu@intel.com, matthew.gerlach@intel.com,
	richard.gong@intel.com
Subject: Re: [PATCH v1 2/5] fpga: altera-pr-ip: Remove fpga_mgr_unregister() call
Date: Wed, 9 Jun 2021 23:37:25 +0800	[thread overview]
Message-ID: <20210609153725.GB1994229@yilunxu-OptiPlex-7050> (raw)
In-Reply-To: <20210609004925.238044-3-russell.h.weight@intel.com>

On Tue, Jun 08, 2021 at 05:49:22PM -0700, Russ Weight wrote:
> The altera-pr-ip driver uses the devm_fpga_mgr_register() call, so it is
> unnecessary to call fpga_mgr_unregister(). Also, mgr is no longer stored
> in the dev.driver_data, so remove the call to dev_get_drvdata().
> 
> alt_pr_unregister() is now an empty function, but is left intact because
> it is an exported symbol.

I don't see this function be called anywhere, so could we just remove
it?

Any impact we remove an exported symbol that is not used?

Thanks,
Yilun

> 
> Signed-off-by: Russ Weight <russell.h.weight@intel.com>
> ---
>  drivers/fpga/altera-pr-ip-core.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/fpga/altera-pr-ip-core.c b/drivers/fpga/altera-pr-ip-core.c
> index 5b130c4d9882..c150a084e440 100644
> --- a/drivers/fpga/altera-pr-ip-core.c
> +++ b/drivers/fpga/altera-pr-ip-core.c
> @@ -201,11 +201,7 @@ EXPORT_SYMBOL_GPL(alt_pr_register);
>  
>  void alt_pr_unregister(struct device *dev)
>  {
> -	struct fpga_manager *mgr = dev_get_drvdata(dev);
> -
>  	dev_dbg(dev, "%s\n", __func__);
> -
> -	fpga_mgr_unregister(mgr);
>  }
>  EXPORT_SYMBOL_GPL(alt_pr_unregister);
>  
> -- 
> 2.25.1