From: Changbin Du <changbin.du@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Changbin Du <changbin.du@gmail.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org,
Cong Wang <xiyou.wangcong@gmail.com>,
David Laight <David.Laight@ACULAB.COM>,
Christian Brauner <christian.brauner@ubuntu.com>
Subject: Re: [PATCH v3] net: make get_net_ns return error if NET_NS is disabled
Date: Fri, 11 Jun 2021 21:53:50 +0800 [thread overview]
Message-ID: <20210611135350.ba2rsbggb3zmunqg@mail.google.com> (raw)
In-Reply-To: <20210610105112.787a0d5f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On Thu, Jun 10, 2021 at 10:51:12AM -0700, Jakub Kicinski wrote:
> On Thu, 10 Jun 2021 23:39:41 +0800 Changbin Du wrote:
> > There is a panic in socket ioctl cmd SIOCGSKNS when NET_NS is not enabled.
> > The reason is that nsfs tries to access ns->ops but the proc_ns_operations
> > is not implemented in this case.
> >
> > [7.670023] Unable to handle kernel NULL pointer dereference at virtual address 00000010
> > [7.670268] pgd = 32b54000
> > [7.670544] [00000010] *pgd=00000000
> > [7.671861] Internal error: Oops: 5 [#1] SMP ARM
> > [7.672315] Modules linked in:
> > [7.672918] CPU: 0 PID: 1 Comm: systemd Not tainted 5.13.0-rc3-00375-g6799d4f2da49 #16
> > [7.673309] Hardware name: Generic DT based system
> > [7.673642] PC is at nsfs_evict+0x24/0x30
> > [7.674486] LR is at clear_inode+0x20/0x9c
> >
> > The same to tun SIOCGSKNS command.
> >
> > To fix this problem, we make get_net_ns() return -EINVAL when NET_NS is
> > disabled. Meanwhile move it to right place net/core/net_namespace.c.
>
> I'm assuming you went from EOPNOTSUPP to EINVAL to follow what the
> existing helpers in the header do?
>
yes, make them behaviour in the same manner.
> Acked-by: Jakub Kicinski <kuba@kernel.org>
>
> Thanks!
--
Cheers,
Changbin Du
next prev parent reply other threads:[~2021-06-11 13:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-10 15:39 [PATCH v3] net: make get_net_ns return error if NET_NS is disabled Changbin Du
2021-06-10 17:51 ` Jakub Kicinski
2021-06-11 13:53 ` Changbin Du [this message]
2021-06-10 21:18 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210611135350.ba2rsbggb3zmunqg@mail.google.com \
--to=changbin.du@gmail.com \
--cc=David.Laight@ACULAB.COM \
--cc=christian.brauner@ubuntu.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.