Re: [RFC v1 2/6] virtio/vsock: add support for virtio datagram

From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [RFC v1 2/6] virtio/vsock: add support for virtio datagram
Date: Wed, 16 Jun 2021 17:17:35 +0800	[thread overview]
Message-ID: <202106161751.C73bIDTO-lkp@intel.com> (raw)
In-Reply-To: <20210609232501.171257-3-jiang.wang@bytedance.com>

[-- Attachment #1: Type: text/plain, Size: 3126 bytes --]

Hi Jiang,

[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on vhost/linux-next]
[also build test WARNING on tip/perf/core linus/master v5.13-rc6]
[cannot apply to next-20210615]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Jiang-Wang/virtio-vsock-introduce-SOCK_DGRAM-support/20210616-120056
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next
config: x86_64-randconfig-s021-20210615 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.3-341-g8af24329-dirty
        # https://github.com/0day-ci/linux/commit/b156a0ad587c43dbfc98397f01b34fad15054bf0
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Jiang-Wang/virtio-vsock-introduce-SOCK_DGRAM-support/20210616-120056
        git checkout b156a0ad587c43dbfc98397f01b34fad15054bf0
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

sparse warnings: (new ones prefixed by >>)
>> net/vmw_vsock/virtio_transport.c:283:21: sparse: sparse: restricted __le16 degrades to integer
--
>> net/vmw_vsock/virtio_transport_common.c:1055:33: sparse: sparse: restricted __le16 degrades to integer
   net/vmw_vsock/virtio_transport_common.c:1079:13: sparse: sparse: restricted __le16 degrades to integer
>> net/vmw_vsock/virtio_transport_common.c:1079:13: sparse: sparse: cast to restricted __le16

vim +283 net/vmw_vsock/virtio_transport.c

   276	
   277	static int
   278	virtio_transport_send_pkt(struct virtio_vsock_pkt *pkt)
   279	{
   280		struct virtio_vsock *vsock;
   281		int len = pkt->len;
   282	
 > 283		if (pkt->hdr.type == VIRTIO_VSOCK_TYPE_DGRAM)
   284			return virtio_transport_send_dgram_pkt(pkt);
   285	
   286		rcu_read_lock();
   287		vsock = rcu_dereference(the_virtio_vsock);
   288		if (!vsock) {
   289			virtio_transport_free_pkt(pkt);
   290			len = -ENODEV;
   291			goto out_rcu;
   292		}
   293	
   294		if (le64_to_cpu(pkt->hdr.dst_cid) == vsock->guest_cid) {
   295			virtio_transport_free_pkt(pkt);
   296			len = -ENODEV;
   297			goto out_rcu;
   298		}
   299	
   300		if (pkt->reply)
   301			atomic_inc(&vsock->queued_replies);
   302	
   303		spin_lock_bh(&vsock->send_pkt_list_lock);
   304		list_add_tail(&pkt->list, &vsock->send_pkt_list);
   305		spin_unlock_bh(&vsock->send_pkt_list_lock);
   306	
   307		queue_work(virtio_vsock_workqueue, &vsock->send_pkt_work);
   308	
   309	out_rcu:
   310		rcu_read_unlock();
   311		return len;
   312	}
   313	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 37189 bytes --]