From: Peter Lieven <pl@kamp.de>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, idryomov@redhat.com, berrange@redhat.com,
Peter Lieven <pl@kamp.de>,
qemu-devel@nongnu.org, ct@flyingcircus.io, pbonzini@redhat.com,
idryomov@gmail.com, mreitz@redhat.com, dillaman@redhat.com
Subject: [PATCH V4 6/6] block/rbd: drop qemu_rbd_refresh_limits
Date: Fri, 2 Jul 2021 11:09:35 +0200 [thread overview]
Message-ID: <20210702090935.15300-7-pl@kamp.de> (raw)
In-Reply-To: <20210702090935.15300-1-pl@kamp.de>
librbd supports 1 byte alignment for all aio operations.
Currently, there is no API call to query limits from the ceph backend.
So drop the bdrv_refresh_limits completely until there is such an API call.
Signed-off-by: Peter Lieven <pl@kamp.de>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
---
block/rbd.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/block/rbd.c b/block/rbd.c
index 149317d33c..93f4bc8b93 100644
--- a/block/rbd.c
+++ b/block/rbd.c
@@ -228,14 +228,6 @@ done:
return;
}
-
-static void qemu_rbd_refresh_limits(BlockDriverState *bs, Error **errp)
-{
- /* XXX Does RBD support AIO on less than 512-byte alignment? */
- bs->bl.request_alignment = 512;
-}
-
-
static int qemu_rbd_set_auth(rados_t cluster, BlockdevOptionsRbd *opts,
Error **errp)
{
@@ -1130,7 +1122,6 @@ static BlockDriver bdrv_rbd = {
.format_name = "rbd",
.instance_size = sizeof(BDRVRBDState),
.bdrv_parse_filename = qemu_rbd_parse_filename,
- .bdrv_refresh_limits = qemu_rbd_refresh_limits,
.bdrv_file_open = qemu_rbd_open,
.bdrv_close = qemu_rbd_close,
.bdrv_reopen_prepare = qemu_rbd_reopen_prepare,
--
2.17.1
next prev parent reply other threads:[~2021-07-02 9:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-02 9:09 [PATCH V4 0/6] block/rbd: migrate to coroutines and add write zeroes support Peter Lieven
2021-07-02 9:09 ` [PATCH V4 1/6] block/rbd: bump librbd requirement to luminous release Peter Lieven
2021-07-02 10:43 ` Ilya Dryomov
2021-07-02 9:09 ` [PATCH V4 2/6] block/rbd: store object_size in BDRVRBDState Peter Lieven
2021-07-02 9:09 ` [PATCH V4 3/6] block/rbd: update s->image_size in qemu_rbd_getlength Peter Lieven
2021-07-02 10:45 ` Ilya Dryomov
2021-07-02 9:09 ` [PATCH V4 4/6] block/rbd: migrate from aio to coroutines Peter Lieven
2021-07-02 10:57 ` Ilya Dryomov
2021-07-02 9:09 ` [PATCH V4 5/6] block/rbd: add write zeroes support Peter Lieven
2021-07-02 12:24 ` Ilya Dryomov
2021-07-02 9:09 ` Peter Lieven [this message]
2021-07-02 12:46 ` [PATCH V4 0/6] block/rbd: migrate to coroutines and " Ilya Dryomov
2021-07-02 13:15 ` Peter Lieven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210702090935.15300-7-pl@kamp.de \
--to=pl@kamp.de \
--cc=berrange@redhat.com \
--cc=ct@flyingcircus.io \
--cc=dillaman@redhat.com \
--cc=idryomov@gmail.com \
--cc=idryomov@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.