From: Olaf Hering <olaf@aepfle.de>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
Juergen Gross <jgross@suse.com>, Jan Beulich <JBeulich@suse.com>
Subject: Re: [PATCH 1/2] tools/migration: Fix iovec handling in send_checkpoint_dirty_pfn_list()
Date: Tue, 6 Jul 2021 14:20:10 +0200 [thread overview]
Message-ID: <20210706142010.3555a487.olaf@aepfle.de> (raw)
In-Reply-To: <20210706112332.31753-2-andrew.cooper3@citrix.com>
[-- Attachment #1: Type: text/plain, Size: 385 bytes --]
Am Tue, 6 Jul 2021 12:23:31 +0100
schrieb Andrew Cooper <andrew.cooper3@citrix.com>:
> We shouldn't be using two struct iovec's to write half of 'rec' each, and
> there is no need to malloc() for two struct iovec's at all.
>
> Simplify down to just two - one covering the whole of 'rec', and one covering
> the pfns array.
Acked-by: Olaf Hering <olaf@aepfle.de>
Olaf
[-- Attachment #2: Digitale Signatur von OpenPGP --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-07-06 12:20 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-06 11:23 [PATCH 0/2] tools/migration: Fixes in send_checkpoint_dirty_pfn_list() Andrew Cooper
2021-07-06 11:23 ` [PATCH 1/2] tools/migration: Fix iovec handling " Andrew Cooper
2021-07-06 11:54 ` Jan Beulich
2021-07-06 12:20 ` Olaf Hering [this message]
2021-07-06 11:23 ` [PATCH 2/2] tools/migration: Fix potential overflow " Andrew Cooper
2021-07-06 12:03 ` Jan Beulich
2021-07-06 13:34 ` Andrew Cooper
2021-07-06 14:00 ` Jan Beulich
2021-07-06 12:58 ` Olaf Hering
2021-07-06 13:19 ` Andrew Cooper
2021-07-06 13:22 ` Andrew Cooper
2021-07-06 13:39 ` Olaf Hering
2021-07-06 13:43 ` Andrew Cooper
2021-07-06 13:28 ` Olaf Hering
2021-07-06 13:56 ` Jan Beulich
2021-07-06 14:11 ` Olaf Hering
2021-07-06 15:13 ` Jan Beulich
2021-07-06 15:22 ` Jan Beulich
2021-07-06 16:08 ` Andrew Cooper
2021-07-06 12:07 ` [PATCH 0/2] tools/migration: Fixes " Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210706142010.3555a487.olaf@aepfle.de \
--to=olaf@aepfle.de \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=iwj@xenproject.org \
--cc=jgross@suse.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.