All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
Cc: Anthony PERARD <anthony.perard@citrix.com>,
	Doug Goldstein <cardoe@cardoe.com>
Subject: [XEN PATCH 2/2] automation: Check if ninja is available before building QEMU
Date: Wed, 7 Jul 2021 17:40:01 +0100	[thread overview]
Message-ID: <20210707164001.894805-3-anthony.perard@citrix.com> (raw)
In-Reply-To: <20210707164001.894805-1-anthony.perard@citrix.com>

ninja is now required to build the latest version of QEMU, some
container still don't have ninja and attempting to add it breaks the
build for different reasons, so QEMU will be skip on those containers.

Failures:
- ubuntu/xenial:
    fatal: ninja version (1.5.1) incompatible with build file ninja_required_version version (1.7.1).
- debian/unstable-i386: (debian-unstable-32)
    /build/tools/flask/policy/Makefile.common:115: *** target pattern contains no '%'.  Stop.
- suse/opensuse-tumbleweed:
    failed to build iPXE
- debian/unstable:
    update of the container fails with:
        The following packages have unmet dependencies:
         clang-8 : Depends: libstdc++-8-dev but it is not installable
                   Depends: libgcc-8-dev but it is not installable
                   Depends: libobjc-8-dev but it is not installable
                   Recommends: llvm-8-dev but it is not going to be installed
                   Recommends: libomp-8-dev but it is not going to be installed

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 automation/scripts/build | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/automation/scripts/build b/automation/scripts/build
index 46b6903d2922..d8c77e244cda 100755
--- a/automation/scripts/build
+++ b/automation/scripts/build
@@ -46,7 +46,9 @@ if ! test -z "$(ldd /bin/ls|grep musl|head -1)"; then
 fi
 
 # Qemu requires Python 3.5 or later
-if ! type python3 || python3 -c "import sys; res = sys.version_info < (3, 5); exit(not(res))"; then
+# QEMU requires ninja
+if ! type python3 || python3 -c "import sys; res = sys.version_info < (3, 5); exit(not(res))" \
+        || ! type ninja; then
     cfgargs+=("--with-system-qemu=/bin/false")
 fi
 
-- 
Anthony PERARD



  parent reply	other threads:[~2021-07-07 16:43 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-07 16:39 [XEN PATCH 0/2] automation: Fix build with new qemu-xen version Anthony PERARD
2021-07-07 16:40 ` [XEN PATCH 1/2] automation: Adding ninja-build to some docker images Anthony PERARD
2021-07-07 16:40 ` Anthony PERARD [this message]
2021-07-07 17:46   ` [XEN PATCH 2/2] automation: Check if ninja is available before building QEMU Andrew Cooper
2021-07-07 19:52     ` Olaf Hering
2021-07-07 22:44       ` Andrew Cooper
2021-07-08  0:29         ` Olaf Hering
2021-07-07 20:35     ` Olaf Hering
2021-07-07 22:47       ` Andrew Cooper
2021-07-08  0:32         ` Olaf Hering
2021-07-08 12:23           ` Olaf Hering
2021-07-08 12:51             ` Andrew Cooper
2021-07-08 14:20               ` Olaf Hering
2021-07-08 10:52     ` Anthony PERARD
2021-07-08 11:23       ` Andrew Cooper
2021-07-08 11:30         ` Anthony PERARD
2021-07-07 17:23 ` [XEN PATCH 0/2] automation: Fix build with new qemu-xen version Anthony PERARD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210707164001.894805-3-anthony.perard@citrix.com \
    --to=anthony.perard@citrix.com \
    --cc=cardoe@cardoe.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.