From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Andreas Kemnade <andreas@kemnade.info>
Cc: Jonathan Cameron <jic23@kernel.org>, <lars@metafoo.de>,
<sre@kernel.org>, <linux-iio@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-pm@vger.kernel.org>,
<letux-kernel@openphoenux.org>
Subject: Re: [PATCH v2 2/2] power: supply: rn5t618: Add voltage_now property
Date: Mon, 12 Jul 2021 11:15:19 +0100 [thread overview]
Message-ID: <20210712111519.00000ef7@Huawei.com> (raw)
In-Reply-To: <20210712091130.2096cf23@aktux>
On Mon, 12 Jul 2021 09:11:30 +0200
Andreas Kemnade <andreas@kemnade.info> wrote:
> On Sun, 11 Jul 2021 11:20:39 +0100
> Jonathan Cameron <jic23@kernel.org> wrote:
>
> > On Mon, 5 Jul 2021 13:36:37 +0200
> > Andreas Kemnade <andreas@kemnade.info> wrote:
> >
> > > Read voltage_now via IIO and provide the property.
> > >
> > > Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> > > Reported-by: kernel test robot <lkp@intel.com>
> > Huh? Seems unlikely it pointed out that this patch was necessary in general.
> > If highlighting a particular fix in an earlier version, then state what it was
> > in the commit message. Note for fixes that get rolled into patches, it's
> > often just mentioned in the change log and we skip the tag because it can
> > cause confusion.
> >
> The robot found a problem in v1 (missing depends on IIO). It is fixed
> now. The message from the bot tells to add a tag. It seems not to make
> sense. But probably the bot is also running on public branches (which
> will not be rebase) and uses the same message where it actually makes
> sense.
Yup. It might be helpful if they modified that message to suggest
commented format if the fix is rolled into an existing patch. I've seen
things like.
Reported-by: kernel test robot <lkp@intel.com> # Fix something interesting.
Which makes it clear what is going on.
Jonathan
>
> I will send a v3 with that tag removed and the other comment addressed.
>
> Regards,
> Andreas
prev parent reply other threads:[~2021-07-12 10:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-05 11:36 [PATCH v2 0/2] mfd: rn5t618: Extend ADC support Andreas Kemnade
2021-07-05 11:36 ` [PATCH v2 1/2] iio: adc: rn5t618: Add iio map Andreas Kemnade
2021-07-11 10:21 ` Jonathan Cameron
2021-07-05 11:36 ` [PATCH v2 2/2] power: supply: rn5t618: Add voltage_now property Andreas Kemnade
2021-07-11 10:20 ` Jonathan Cameron
2021-07-12 7:11 ` Andreas Kemnade
2021-07-12 10:15 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210712111519.00000ef7@Huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=andreas@kemnade.info \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=letux-kernel@openphoenux.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.