From: Huang Ying <ying.huang@intel.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Dave Hansen <dave.hansen@linux.intel.com>,
"Huang, Ying" <ying.huang@intel.com>,
Yang Shi <yang.shi@linux.alibaba.com>,
Yang Shi <shy828301@gmail.com>, Michal Hocko <mhocko@suse.com>,
Wei Xu <weixugc@google.com>, osalvador <osalvador@suse.de>,
Zi Yan <ziy@nvidia.com>, David Rientjes <rientjes@google.com>,
Dan Williams <dan.j.williams@intel.com>,
David Hildenbrand <david@redhat.com>
Subject: [PATCH -V10 8/9] mm/vmscan: never demote for memcg reclaim
Date: Thu, 15 Jul 2021 13:51:44 +0800 [thread overview]
Message-ID: <20210715055145.195411-9-ying.huang@intel.com> (raw)
In-Reply-To: <20210715055145.195411-1-ying.huang@intel.com>
From: Dave Hansen <dave.hansen@linux.intel.com>
Global reclaim aims to reduce the amount of memory used on
a given node or set of nodes. Migrating pages to another
node serves this purpose.
memcg reclaim is different. Its goal is to reduce the
total memory consumption of the entire memcg, across all
nodes. Migration does not assist memcg reclaim because
it just moves page contents between nodes rather than
actually reducing memory consumption.
Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
Signed-off-by: "Huang, Ying" <ying.huang@intel.com>
Suggested-by: Yang Shi <yang.shi@linux.alibaba.com>
Reviewed-by: Yang Shi <shy828301@gmail.com>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Wei Xu <weixugc@google.com>
Cc: osalvador <osalvador@suse.de>
Cc: Zi Yan <ziy@nvidia.com>
Cc: David Rientjes <rientjes@google.com>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: David Hildenbrand <david@redhat.com>
--
changes from 20210618:
* Avoid to scan anon lists for demotion for cgroup reclaim.
---
mm/vmscan.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/mm/vmscan.c b/mm/vmscan.c
index 0f9be998230f..b697f1a6108c 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -521,8 +521,13 @@ static long add_nr_deferred(long nr, struct shrinker *shrinker,
static bool can_demote_anon_pages(int nid, struct scan_control *sc)
{
- if (sc && sc->no_demotion)
- return false;
+ if (sc) {
+ if (sc->no_demotion)
+ return false;
+ /* It is pointless to do demotion in memcg reclaim */
+ if (cgroup_reclaim(sc))
+ return false;
+ }
if (next_demotion_node(nid) == NUMA_NO_NODE)
return false;
--
2.30.2
next prev parent reply other threads:[~2021-07-15 5:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-15 5:51 [PATCH -V10 0/9] Migrate Pages in lieu of discard Huang Ying
2021-07-15 5:51 ` [PATCH -V10 1/9] mm/numa: automatically generate node migration order Huang Ying
2021-07-15 17:52 ` Zi Yan
2021-07-15 5:51 ` [PATCH -V10 2/9] mm/migrate: update node demotion order on hotplug events Huang Ying
2021-07-15 18:00 ` Zi Yan
2021-07-15 5:51 ` [PATCH -V10 3/9] mm/migrate: enable returning precise migrate_pages() success count Huang Ying
2021-07-15 18:02 ` Zi Yan
2021-07-15 5:51 ` [PATCH -V10 4/9] mm/migrate: demote pages during reclaim Huang Ying
2021-07-15 5:51 ` [PATCH -V10 5/9] mm/vmscan: add page demotion counter Huang Ying
2021-07-15 5:51 ` [PATCH -V10 6/9] mm/vmscan: add helper for querying ability to age anonymous pages Huang Ying
2021-07-15 5:51 ` [PATCH -V10 7/9] mm/vmscan: Consider anonymous pages without swap Huang Ying
2021-07-15 5:51 ` Huang Ying [this message]
2021-07-15 5:51 ` [PATCH -V10 9/9] mm/migrate: add sysfs interface to enable reclaim migration Huang Ying
2021-07-15 19:38 ` [PATCH -V10 0/9] Migrate Pages in lieu of discard Andrew Morton
2021-07-15 21:42 ` Dave Hansen
2021-07-16 1:10 ` Matthew Wilcox
2021-07-16 3:32 ` Huang, Ying
2021-07-16 3:32 ` Huang, Ying
2021-07-16 3:54 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210715055145.195411-9-ying.huang@intel.com \
--to=ying.huang@intel.com \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=osalvador@suse.de \
--cc=rientjes@google.com \
--cc=shy828301@gmail.com \
--cc=weixugc@google.com \
--cc=yang.shi@linux.alibaba.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.