Re: [PATCH v9 08/17] virtio_config: Add a return value to reset function

From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v9 08/17] virtio_config: Add a return value to reset function
Date: Fri, 16 Jul 2021 04:37:28 +0800	[thread overview]
Message-ID: <202107160454.4d4W4XVT-lkp@intel.com> (raw)
In-Reply-To: <20210713084656.232-9-xieyongji@bytedance.com>

[-- Attachment #1: Type: text/plain, Size: 3516 bytes --]

Hi Xie,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on vhost/linux-next]
[also build test ERROR on iommu/next uml/linux-next s390/features linus/master v5.14-rc1 next-20210715]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Xie-Yongji/Introduce-VDUSE-vDPA-Device-in-Userspace/20210713-165009
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next
config: x86_64-randconfig-a005-20210713 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 8d69635ed9ecf36fd0ca85906bfde17949671cbe)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # https://github.com/0day-ci/linux/commit/ade2af66f29301fe5d897bfddfabc27f5f5cd678
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Xie-Yongji/Introduce-VDUSE-vDPA-Device-in-Userspace/20210713-165009
        git checkout ade2af66f29301fe5d897bfddfabc27f5f5cd678
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/virtio/virtio_mmio.c:537:12: error: incompatible function pointer types initializing 'int (*)(struct virtio_device *)' with an expression of type 'void (struct virtio_device *)' [-Werror,-Wincompatible-function-pointer-types]
           .reset          = vm_reset,
                             ^~~~~~~~
   1 error generated.

vim +537 drivers/virtio/virtio_mmio.c

38e895487afc2ed Sebastien Boeuf    2020-08-19  530  
9350393239153c4 Stephen Hemminger  2013-02-10  531  static const struct virtio_config_ops virtio_mmio_config_ops = {
edfd52e6367270c Pawel Moll         2011-10-24  532  	.get		= vm_get,
edfd52e6367270c Pawel Moll         2011-10-24  533  	.set		= vm_set,
87e7bf1450c9f6b Michael S. Tsirkin 2015-03-12  534  	.generation	= vm_generation,
edfd52e6367270c Pawel Moll         2011-10-24  535  	.get_status	= vm_get_status,
edfd52e6367270c Pawel Moll         2011-10-24  536  	.set_status	= vm_set_status,
edfd52e6367270c Pawel Moll         2011-10-24 @537  	.reset		= vm_reset,
edfd52e6367270c Pawel Moll         2011-10-24  538  	.find_vqs	= vm_find_vqs,
edfd52e6367270c Pawel Moll         2011-10-24  539  	.del_vqs	= vm_del_vqs,
edfd52e6367270c Pawel Moll         2011-10-24  540  	.get_features	= vm_get_features,
edfd52e6367270c Pawel Moll         2011-10-24  541  	.finalize_features = vm_finalize_features,
66846048f55c6c0 Rick Jones         2011-11-14  542  	.bus_name	= vm_bus_name,
38e895487afc2ed Sebastien Boeuf    2020-08-19  543  	.get_shm_region = vm_get_shm_region,
edfd52e6367270c Pawel Moll         2011-10-24  544  };
edfd52e6367270c Pawel Moll         2011-10-24  545  
edfd52e6367270c Pawel Moll         2011-10-24  546  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 52816 bytes --]