Re: [PATCH 0/1] spi: spi-bcm2835: Fix deadlock

From: Mark Brown <broonie@kernel.org>
To: "Sa, Nuno" <Nuno.Sa@analog.com>
Cc: "Tachici, Alexandru" <Alexandru.Tachici@analog.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
	"nsaenz@kernel.org" <nsaenz@kernel.org>,
	"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
	"rjui@broadcom.com" <rjui@broadcom.com>,
	"swarren@wwwdotorg.org" <swarren@wwwdotorg.org>,
	"bcm-kernel-feedback-list@broadcom.com" 
	<bcm-kernel-feedback-list@broadcom.com>,
	"bootc@bootc.net" <bootc@bootc.net>
Subject: Re: [PATCH 0/1] spi: spi-bcm2835: Fix deadlock
Date: Wed, 21 Jul 2021 13:32:07 +0100	[thread overview]
Message-ID: <20210721123207.GD4259@sirena.org.uk> (raw)
In-Reply-To: <PH0PR03MB6366CFFFF5846F7018FFA03699E39@PH0PR03MB6366.namprd03.prod.outlook.com>

[-- Attachment #1: Type: text/plain, Size: 1549 bytes --]

On Wed, Jul 21, 2021 at 06:47:01AM +0000, Sa, Nuno wrote:
> > To: Tachici, Alexandru <Alexandru.Tachici@analog.com>; linux-
> > kernel@vger.kernel.org; linux-spi@vger.kernel.org
> > Cc: Mark Brown <broonie@kernel.org>; nsaenz@kernel.org;
> > f.fainelli@gmail.com; rjui@broadcom.com; swarren@wwwdotorg.org;
> > bcm-kernel-feedback-list@broadcom.com; bootc@bootc.net; Sa,
> > Nuno <Nuno.Sa@analog.com>
> > Subject: Re: [PATCH 0/1] spi: spi-bcm2835: Fix deadlock

Please delete unneeded context from mails when replying.  Doing this
makes it much easier to find your reply in the message, helping ensure
it won't be missed by people scrolling through the irrelevant quoted
material.

> I'm really curious about this one and how should we proceed. Maybe this is not
> new (just to me) and the way to go is just to "fix" the spi controller when we hit the
> issue? I'm asking this because there's a more fundamental problem when this pieces
> align together (CCF + SPI). What I mean is that this can potentially happen in every
> system that happens to have a spi based clock provider and in which the spi controller
> tries to access the CCF in the spi transfer function... Doing a quick and short look I can
> already see that [1], [2], [3] and [4] could hit the same deadlock...

The clock API just doesn't work very well for things on buses that might
sleep, I2C is another example - it's a long standing general issue that
needs to be addressed in the clock framework for example with finer
grained locking but nobody has come up with anything yet.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]