From: Mark Brown <broonie@kernel.org>
To: David Rhodes <drhodes@opensource.cirrus.com>
Cc: robh@kernel.org, brian.austin@cirrus.com,
Charles Keepax <ckeepax@opensource.cirrus.com>,
patches@opensource.cirrus.com, alsa-devel@alsa-project.org,
david.rhodes@cirrus.com
Subject: Re: [PATCH v3 1/2] ASoC: cs35l41: CS35L41 Boosted Smart Amplifier
Date: Thu, 22 Jul 2021 17:11:21 +0100 [thread overview]
Message-ID: <20210722161121.GE5258@sirena.org.uk> (raw)
In-Reply-To: <198c7169-8885-aa50-5ab4-cf53cafb16be@opensource.cirrus.com>
[-- Attachment #1: Type: text/plain, Size: 551 bytes --]
On Thu, Jul 22, 2021 at 11:07:20AM -0500, David Rhodes wrote:
> On 7/21/21 4:01 AM, Charles Keepax wrote:
> > why that is necessary in the first place. AFAIK DAPM won't attempt
> > to power down a widget without powering it up first. So, at least
> > to me, its not clear how you get to this code without GLOBAL_EN
> > having first been set by the power up?
> This is a case where the bit controlling the widget defaults to enabled.
> Would it be better to clear that bit before registering the codec?
That's probably a clearer and simpler option.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-07-22 16:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-02 20:51 [PATCH v3 0/2] Cirrus Logic CS35L41 Amplifier David Rhodes
2021-07-02 20:51 ` [PATCH v3 1/2] ASoC: cs35l41: CS35L41 Boosted Smart Amplifier David Rhodes
2021-07-05 19:20 ` Mark Brown
2021-07-09 23:11 ` David Rhodes
2021-07-12 15:03 ` Mark Brown
2021-07-20 22:18 ` David Rhodes
2021-07-21 9:01 ` Charles Keepax
2021-07-21 12:03 ` Mark Brown
2021-07-22 16:07 ` David Rhodes
2021-07-22 16:11 ` Mark Brown [this message]
2021-07-02 20:51 ` [PATCH v3 2/2] ASoC: cs35l41: Add bindings for CS35L41 David Rhodes
2021-07-05 19:28 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210722161121.GE5258@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=brian.austin@cirrus.com \
--cc=ckeepax@opensource.cirrus.com \
--cc=david.rhodes@cirrus.com \
--cc=drhodes@opensource.cirrus.com \
--cc=patches@opensource.cirrus.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.