Re: [RFC][Patch v1 2/2] iommu/arm-smmu-v3: Add support for NVIDIA CMDQ-Virtualization hw

From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [RFC][Patch v1 2/2] iommu/arm-smmu-v3: Add support for NVIDIA CMDQ-Virtualization hw
Date: Sat, 24 Jul 2021 08:55:15 +0800	[thread overview]
Message-ID: <202107240842.Ipqd3Hio-lkp@intel.com> (raw)
In-Reply-To: <20210723193140.9690-3-nicolinc@nvidia.com>

[-- Attachment #1: Type: text/plain, Size: 3387 bytes --]

Hi Nicolin,

[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on iommu/next]
[also build test WARNING on tegra/for-next tegra-drm/drm/tegra/for-next linus/master v5.14-rc2 next-20210723]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Nicolin-Chen/iommu-arm-smmu-v3-Add-NVIDIA-implementation/20210724-033346
base:   https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git next
config: arm64-allyesconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/3c3adc4970f0dd2ff7ffeadadbf16d9b85315712
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Nicolin-Chen/iommu-arm-smmu-v3-Add-NVIDIA-implementation/20210724-033346
        git checkout 3c3adc4970f0dd2ff7ffeadadbf16d9b85315712
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/iommu/arm/arm-smmu-v3/nvidia-smmu-v3.c:368:21: warning: no previous prototype for 'nvidia_smmu_create' [-Wmissing-prototypes]
     368 | struct nvidia_smmu *nvidia_smmu_create(struct arm_smmu_device *smmu)
         |                     ^~~~~~~~~~~~~~~~~~

vim +/nvidia_smmu_create +368 drivers/iommu/arm/arm-smmu-v3/nvidia-smmu-v3.c

   366	
   367	#ifdef CONFIG_ACPI
 > 368	struct nvidia_smmu *nvidia_smmu_create(struct arm_smmu_device *smmu)
   369	{
   370		struct nvidia_smmu *nsmmu = NULL;
   371		struct acpi_iort_node *node;
   372		struct acpi_device *adev;
   373		struct device *cmdqv_dev;
   374		const char *match_uid;
   375	
   376		if (acpi_disabled)
   377			return NULL;
   378	
   379		/* Look for a device in the DSDT whose _UID matches the SMMU's iort_node identifier */
   380		node = *(struct acpi_iort_node **)dev_get_platdata(smmu->dev);
   381		match_uid = kasprintf(GFP_KERNEL, "%u", node->identifier);
   382		adev = acpi_dev_get_first_match_dev(NVIDIA_SMMU_CMDQV_HID, match_uid, -1);
   383		kfree(match_uid);
   384	
   385		if (!adev)
   386			return NULL;
   387	
   388		cmdqv_dev = bus_find_device_by_acpi_dev(&platform_bus_type, adev);
   389		if (!cmdqv_dev)
   390			return NULL;
   391	
   392		dev_info(smmu->dev, "found companion CMDQV device, %s", dev_name(cmdqv_dev));
   393	
   394		nsmmu = devm_krealloc(smmu->dev, smmu, sizeof(*nsmmu), GFP_KERNEL);
   395		if (!nsmmu)
   396			return ERR_PTR(-ENOMEM);
   397	
   398		nsmmu->cmdqv_dev = cmdqv_dev;
   399	
   400		return nsmmu;
   401	}
   402	#else
   403	struct nvidia_smmu *nvidia_smmu_create(struct arm_smmu_device *smmu)
   404	{
   405		return NULL;
   406	}
   407	#endif
   408	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 77918 bytes --]