Re: [PATCH] ALSA: memalloc: Fix pgprot for WC mmap on x86

From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH] ALSA: memalloc: Fix pgprot for WC mmap on x86
Date: Wed, 04 Aug 2021 22:48:04 +0800	[thread overview]
Message-ID: <202108042221.5PWjOfV9-lkp@intel.com> (raw)
In-Reply-To: <20210804061329.29265-1-tiwai@suse.de>

[-- Attachment #1: Type: text/plain, Size: 2383 bytes --]

Hi Takashi,

I love your patch! Yet something to improve:

[auto build test ERROR on sound/for-next]
[also build test ERROR on v5.14-rc4 next-20210803]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Takashi-Iwai/ALSA-memalloc-Fix-pgprot-for-WC-mmap-on-x86/20210804-141649
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next
config: x86_64-kexec (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/2221a300a3d8cf7fbf463f6f0726daac3f38bd12
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Takashi-Iwai/ALSA-memalloc-Fix-pgprot-for-WC-mmap-on-x86/20210804-141649
        git checkout 2221a300a3d8cf7fbf463f6f0726daac3f38bd12
        # save the attached .config to linux build tree
        mkdir build_dir
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   sound/core/memalloc.c: In function 'snd_dma_dev_mmap':
>> sound/core/memalloc.c:418:24: error: 'SNDRV_DMA_TYPE_DEV_WC' undeclared (first use in this function); did you mean 'SNDRV_DMA_TYPE_DEV_UC'?
     418 |  if (dmab->dev.type == SNDRV_DMA_TYPE_DEV_WC)
         |                        ^~~~~~~~~~~~~~~~~~~~~
         |                        SNDRV_DMA_TYPE_DEV_UC
   sound/core/memalloc.c:418:24: note: each undeclared identifier is reported only once for each function it appears in

vim +418 sound/core/memalloc.c

   413	
   414	static int snd_dma_dev_mmap(struct snd_dma_buffer *dmab,
   415				    struct vm_area_struct *area)
   416	{
   417	#ifdef CONFIG_X86
 > 418		if (dmab->dev.type == SNDRV_DMA_TYPE_DEV_WC)
   419			area->vm_page_prot = pgprot_writecombine(area->vm_page_prot);
   420	#endif
   421		return dma_mmap_coherent(dmab->dev.dev, area,
   422					 dmab->area, dmab->addr, dmab->bytes);
   423	}
   424	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 28993 bytes --]