Re: [PATCH v3 07/10] media: rkvdec: Add the VP9 backend

From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v3 07/10] media: rkvdec: Add the VP9 backend
Date: Fri, 06 Aug 2021 04:14:57 +0800	[thread overview]
Message-ID: <202108060449.d5kjb5TB-lkp@intel.com> (raw)
In-Reply-To: <20210805144246.11998-8-andrzej.p@collabora.com>

[-- Attachment #1: Type: text/plain, Size: 3992 bytes --]

Hi Andrzej,

I love your patch! Perhaps something to improve:

[auto build test WARNING on bfee75f73c37a2f46a6326eaa06f5db701f76f01]

url:    https://github.com/0day-ci/linux/commits/Andrzej-Pietrasiewicz/VP9-codec-V4L2-control-interface/20210805-224717
base:   bfee75f73c37a2f46a6326eaa06f5db701f76f01
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/babc0bba621efcae4556da29717e9ae86b7238fa
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Andrzej-Pietrasiewicz/VP9-codec-V4L2-control-interface/20210805-224717
        git checkout babc0bba621efcae4556da29717e9ae86b7238fa
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross ARCH=m68k 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/staging/media/rkvdec/rkvdec-vp9.c: In function 'init_intra_only_probs':
>> drivers/staging/media/rkvdec/rkvdec-vp9.c:190:36: warning: variable 'dec_params' set but not used [-Wunused-but-set-variable]
     190 |  const struct v4l2_ctrl_vp9_frame *dec_params;
         |                                    ^~~~~~~~~~
   drivers/staging/media/rkvdec/rkvdec-vp9.c: In function 'init_inter_probs':
   drivers/staging/media/rkvdec/rkvdec-vp9.c:245:36: warning: variable 'dec_params' set but not used [-Wunused-but-set-variable]
     245 |  const struct v4l2_ctrl_vp9_frame *dec_params;
         |                                    ^~~~~~~~~~

vim +/dec_params +190 drivers/staging/media/rkvdec/rkvdec-vp9.c

   186	
   187	static void init_intra_only_probs(struct rkvdec_ctx *ctx,
   188					  const struct rkvdec_vp9_run *run)
   189	{
 > 190		const struct v4l2_ctrl_vp9_frame *dec_params;
   191		struct rkvdec_vp9_ctx *vp9_ctx = ctx->priv;
   192		struct rkvdec_vp9_priv_tbl *tbl = vp9_ctx->priv_tbl.cpu;
   193		struct rkvdec_vp9_intra_only_frame_probs *rkprobs;
   194		const struct v4l2_vp9_frame_context *probs;
   195		unsigned int i, j, k, m;
   196	
   197		rkprobs = &tbl->probs.intra_only;
   198		dec_params = run->decode_params;
   199		probs = &vp9_ctx->probability_tables;
   200	
   201		/*
   202		 * intra only 149 x 128 bits ,aligned to 152 x 128 bits coeff related
   203		 * prob 64 x 128 bits
   204		 */
   205		for (i = 0; i < ARRAY_SIZE(probs->coef); i++) {
   206			for (j = 0; j < ARRAY_SIZE(probs->coef[0]); j++)
   207				write_coeff_plane(probs->coef[i][j][0],
   208						  rkprobs->coef_intra[i][j]);
   209		}
   210	
   211		/* intra mode prob  80 x 128 bits */
   212		for (i = 0; i < ARRAY_SIZE(v4l2_vp9_kf_y_mode_prob); i++) {
   213			unsigned int byte_count = 0;
   214			int idx = 0;
   215	
   216			/* vp9_kf_y_mode_prob */
   217			for (j = 0; j < ARRAY_SIZE(v4l2_vp9_kf_y_mode_prob[0]); j++) {
   218				for (k = 0; k < ARRAY_SIZE(v4l2_vp9_kf_y_mode_prob[0][0]);
   219				     k++) {
   220					u8 val = v4l2_vp9_kf_y_mode_prob[i][j][k];
   221	
   222					rkprobs->intra_mode[i].y_mode[idx++] = val;
   223					byte_count++;
   224					if (byte_count == 27) {
   225						byte_count = 0;
   226						idx += 5;
   227					}
   228				}
   229			}
   230	
   231			idx = 0;
   232			if (i < 4) {
   233				for (m = 0; m < (i < 3 ? 23 : 21); m++) {
   234					const u8 *ptr = (const u8 *)v4l2_vp9_kf_uv_mode_prob;
   235	
   236					rkprobs->intra_mode[i].uv_mode[idx++] = ptr[i * 23 + m];
   237				}
   238			}
   239		}
   240	}
   241	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 60703 bytes --]