From: Nishanth Menon <nm@ti.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Russell King <linux@armlinux.org.uk>,
<linux-arm-kernel@lists.infradead.org>,
Nishanth Menon <nmenon@kernel.org>,
Grygorii Strashko <grygorii.strashko@ti.com>
Subject: Re: [PATCH v3] ARM: Fix Keystone 2 kernel mapping regression
Date: Mon, 9 Aug 2021 08:47:28 -0500 [thread overview]
Message-ID: <20210809134728.3fy3gczobmdxvxtb@reword> (raw)
In-Reply-To: <20210809115233.1009708-1-linus.walleij@linaro.org>
On 13:52-20210809, Linus Walleij wrote:
> This fixes a Keystone 2 regression discovered as a side effect of
> defining an passing the physical start/end sections of the kernel
> to the MMU remapping code.
>
> As the Keystone applies an offset to all physical addresses,
> including those identified and patches by phys2virt, we fail to
> account for this offset in the kernel_sec_start and kernel_sec_end
> variables.
>
> Further these offsets can extend into the 64bit range on LPAE
> systems such as the Keystone 2.
>
> Fix it like this:
> - Extend kernel_sec_start and kernel_sec_end to be 64bit
> - Add the offset also to kernel_sec_start and kernel_sec_end
>
> As passing kernel_sec_start and kernel_sec_end as 64bit invariably
> incurs BE8 endianness issues I have attempted to dry-code around
> these.
>
> Tested on the Vexpress QEMU model both with and without LPAE
> enabled.
>
> Fixes: 6e121df14ccd ("ARM: 9090/1: Map the lowmem and kernel separately")
> Reported-by: Nishanth Menon <nmenon@kernel.org>
> Suggested-by: Russell King <linux@armlinux.org.uk>
> Tested-by: Grygorii Strashko <grygorii.strashko@ti.com>
> Tested-by: Nishanth Menon <nmenon@kernel.org>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Nishanth Menon <nm@ti.com>
> Link: https://lore.kernel.org/r/20210809115233.1009708-1-linus.walleij@linaro.org
> ---
V3 looks good as well. Thanks.
Test log for v3:
https://pastebin.ubuntu.com/p/RfhFwJf349/ (k2g-evm)
https://pastebin.ubuntu.com/p/QmXsDPwyh9/ (k2hk evm)
Tag used: next-20210809
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2021-08-09 13:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-09 11:52 [PATCH v3] ARM: Fix Keystone 2 kernel mapping regression Linus Walleij
2021-08-09 13:47 ` Nishanth Menon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210809134728.3fy3gczobmdxvxtb@reword \
--to=nm@ti.com \
--cc=grygorii.strashko@ti.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=nmenon@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.