From: Nilesh Javali <njavali@marvell.com>
To: <martin.petersen@oracle.com>
Cc: <linux-scsi@vger.kernel.org>, <GR-QLogic-Storage-Upstream@marvell.com>
Subject: [PATCH v2 10/14] qla2xxx: suppress unnecessary log messages during login
Date: Mon, 9 Aug 2021 21:37:16 -0700 [thread overview]
Message-ID: <20210810043720.1137-11-njavali@marvell.com> (raw)
In-Reply-To: <20210810043720.1137-1-njavali@marvell.com>
From: Arun Easi <aeasi@marvell.com>
Suppress logging of retryable errors. These could still be seen
if extended logging is enabled.
Signed-off-by: Arun Easi <aeasi@marvell.com>
Signed-off-by: Nilesh Javali <njavali@marvell.com>
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
---
drivers/scsi/qla2xxx/qla_init.c | 2 +-
drivers/scsi/qla2xxx/qla_isr.c | 23 +++++++++++++++++------
2 files changed, 18 insertions(+), 7 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c
index df532c5531a9..4f68b4ebcbc4 100644
--- a/drivers/scsi/qla2xxx/qla_init.c
+++ b/drivers/scsi/qla2xxx/qla_init.c
@@ -360,7 +360,7 @@ qla2x00_async_login(struct scsi_qla_host *vha, fc_port_t *fcport,
if (NVME_TARGET(vha->hw, fcport))
lio->u.logio.flags |= SRB_LOGIN_SKIP_PRLI;
- ql_log(ql_log_warn, vha, 0x2072,
+ ql_dbg(ql_dbg_disc, vha, 0x2072,
"Async-login - %8phC hdl=%x, loopid=%x portid=%06x retries=%d.\n",
fcport->port_name, sp->handle, fcport->loop_id,
fcport->d_id.b24, fcport->login_retry);
diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c
index 93ab686c7a30..b0b5af21781a 100644
--- a/drivers/scsi/qla2xxx/qla_isr.c
+++ b/drivers/scsi/qla2xxx/qla_isr.c
@@ -2326,6 +2326,7 @@ qla24xx_logio_entry(scsi_qla_host_t *vha, struct req_que *req,
struct srb_iocb *lio;
uint16_t *data;
uint32_t iop[2];
+ int logit = 1;
sp = qla2x00_get_sp_from_handle(vha, func, req, logio);
if (!sp)
@@ -2403,9 +2404,11 @@ qla24xx_logio_entry(scsi_qla_host_t *vha, struct req_que *req,
case LSC_SCODE_PORTID_USED:
data[0] = MBS_PORT_ID_USED;
data[1] = LSW(iop[1]);
+ logit = 0;
break;
case LSC_SCODE_NPORT_USED:
data[0] = MBS_LOOP_ID_USED;
+ logit = 0;
break;
case LSC_SCODE_CMD_FAILED:
if (iop[1] == 0x0606) {
@@ -2438,12 +2441,20 @@ qla24xx_logio_entry(scsi_qla_host_t *vha, struct req_que *req,
break;
}
- ql_log(ql_log_warn, sp->vha, 0x5037,
- "Async-%s failed: handle=%x pid=%06x wwpn=%8phC comp_status=%x iop0=%x iop1=%x\n",
- type, sp->handle, fcport->d_id.b24, fcport->port_name,
- le16_to_cpu(logio->comp_status),
- le32_to_cpu(logio->io_parameter[0]),
- le32_to_cpu(logio->io_parameter[1]));
+ if (logit)
+ ql_log(ql_log_warn, sp->vha, 0x5037, "Async-%s failed: "
+ "handle=%x pid=%06x wwpn=%8phC comp_status=%x iop0=%x iop1=%x\n",
+ type, sp->handle, fcport->d_id.b24, fcport->port_name,
+ le16_to_cpu(logio->comp_status),
+ le32_to_cpu(logio->io_parameter[0]),
+ le32_to_cpu(logio->io_parameter[1]));
+ else
+ ql_dbg(ql_dbg_disc, sp->vha, 0x5037, "Async-%s failed: "
+ "handle=%x pid=%06x wwpn=%8phC comp_status=%x iop0=%x iop1=%x\n",
+ type, sp->handle, fcport->d_id.b24, fcport->port_name,
+ le16_to_cpu(logio->comp_status),
+ le32_to_cpu(logio->io_parameter[0]),
+ le32_to_cpu(logio->io_parameter[1]));
logio_done:
sp->done(sp, 0);
--
2.19.0.rc0
next prev parent reply other threads:[~2021-08-10 4:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-10 4:37 [PATCH v2 00/14] qla2xxx driver bug fixes Nilesh Javali
2021-08-10 4:37 ` [PATCH v2 01/14] qla2xxx: Add host attribute to trigger MPI hang Nilesh Javali
2021-08-10 4:37 ` [PATCH v2 02/14] qla2xxx: Change %p to %px in the log messages Nilesh Javali
2021-08-10 4:37 ` [PATCH v2 03/14] qla2xxx: adjust request/response queue size for 28xx Nilesh Javali
2021-08-10 4:37 ` [PATCH v2 04/14] qla2xxx: Changes to support FCP2 Target Nilesh Javali
2021-08-10 4:37 ` [PATCH v2 05/14] qla2xxx: Show OS name and version in FDMI-1 Nilesh Javali
2021-08-10 4:37 ` [PATCH v2 06/14] qla2xxx: add debug print of 64G link speed Nilesh Javali
2021-08-10 4:37 ` [PATCH v2 07/14] qla2xxx: fix port type info Nilesh Javali
2021-08-10 4:37 ` [PATCH v2 08/14] qla2xxx: fix unsafe removal from link list Nilesh Javali
2021-08-10 4:37 ` [PATCH v2 09/14] qla2xxx: fix npiv create erroneous error Nilesh Javali
2021-08-10 4:37 ` Nilesh Javali [this message]
2021-08-10 4:37 ` [PATCH v2 11/14] qla2xxx: Changes to support kdump kernel Nilesh Javali
2021-08-10 4:37 ` [PATCH v2 12/14] qla2xxx: Changes to support kdump kernel for NVMe BFS Nilesh Javali
2021-08-10 4:37 ` [PATCH v2 13/14] qla2xxx: Sync queue idx with queue_pair_map idx Nilesh Javali
2021-08-10 4:37 ` [PATCH v2 14/14] qla2xxx: Update version to 10.02.06.100-k Nilesh Javali
2021-08-17 3:17 ` [PATCH v2 00/14] qla2xxx driver bug fixes Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210810043720.1137-11-njavali@marvell.com \
--to=njavali@marvell.com \
--cc=GR-QLogic-Storage-Upstream@marvell.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.