From: Imre Deak <imre.deak@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
Subject: [Intel-gfx] [PATCH v2 3/6] drm/i915/adlp: Assert that VMAs in DPT start at 0
Date: Mon, 6 Sep 2021 21:27:12 +0300 [thread overview]
Message-ID: <20210906182715.3915100-4-imre.deak@intel.com> (raw)
In-Reply-To: <20210906182715.3915100-1-imre.deak@intel.com>
Atm the DPT object can accommodate only one VMA, so the VMA offset will
be always 0. Add an assert for this.
Cc: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>
Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
---
drivers/gpu/drm/i915/display/skl_universal_plane.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane.c b/drivers/gpu/drm/i915/display/skl_universal_plane.c
index 724e7b04f3b63..f50282b60de44 100644
--- a/drivers/gpu/drm/i915/display/skl_universal_plane.c
+++ b/drivers/gpu/drm/i915/display/skl_universal_plane.c
@@ -993,6 +993,11 @@ static u32 skl_surf_address(const struct intel_plane_state *plane_state,
u32 offset = plane_state->view.color_plane[color_plane].offset;
if (intel_fb_uses_dpt(fb)) {
+ /*
+ * The DPT object contains only one vma, so the VMA's offset
+ * within the DPT is always 0.
+ */
+ WARN_ON(plane_state->dpt_vma->node.start);
WARN_ON(offset & 0x1fffff);
return offset >> 9;
} else {
--
2.27.0
next prev parent reply other threads:[~2021-09-06 18:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-06 18:27 [Intel-gfx] [PATCH v2 0/6] drm/i915/adlp: Add support for remapping CCS FBs Imre Deak
2021-09-06 18:27 ` [Intel-gfx] [PATCH v2 1/6] drm/i915: Use tile block based dimensions for CCS origin x, y check Imre Deak
2021-09-07 3:24 ` [Intel-gfx] [CI " Imre Deak
2021-09-06 18:27 ` [Intel-gfx] [PATCH v2 2/6] drm/i915/adlp: Require always a power-of-two sized CCS surface stride Imre Deak
2021-09-06 18:27 ` Imre Deak [this message]
2021-09-06 18:27 ` [Intel-gfx] [PATCH v2 4/6] drm/i915: Follow a new->old platform check order in intel_fb_stride_alignment Imre Deak
2021-09-06 18:27 ` [Intel-gfx] [PATCH v2 5/6] drm/i915/adlp: Add support for remapping CCS FBs Imre Deak
2021-09-06 18:27 ` [PATCH v2 6/6] drm/fourcc: Add the ADL-P specific pitch requirements of CCS modifiers Imre Deak
2021-09-06 18:27 ` [Intel-gfx] " Imre Deak
2021-09-06 19:49 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/adlp: Add support for remapping CCS FBs (rev2) Patchwork
2021-09-06 21:14 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-09-07 2:49 ` [Intel-gfx] [CI 0/6] drm/i915/adlp: Add support for remapping CCS FBs Imre Deak
2021-09-07 3:24 ` Imre Deak
2021-09-07 4:08 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/adlp: Add support for remapping CCS FBs (rev3) Patchwork
2021-09-07 5:25 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-09-07 10:41 ` Imre Deak
2021-09-07 10:56 ` Sarvela, Tomi P
2021-09-23 15:15 ` Imre Deak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210906182715.3915100-4-imre.deak@intel.com \
--to=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=juhapekka.heikkila@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.