From: James Smart <jsmart2021@gmail.com>
To: linux-scsi@vger.kernel.org
Cc: James Smart <jsmart2021@gmail.com>, Justin Tee <justin.tee@broadcom.com>
Subject: [PATCH 11/14] lpfc: Fix I/O block after enabling managed congestion mode
Date: Fri, 10 Sep 2021 16:31:56 -0700 [thread overview]
Message-ID: <20210910233159.115896-12-jsmart2021@gmail.com> (raw)
In-Reply-To: <20210910233159.115896-1-jsmart2021@gmail.com>
If the congestion management framework dynamically enables, it may do
so while I/O is in flight. The updates of cmf info due to inflight
I/O completing may happen before values have been initialized.
Fix by ensure cmf_max_bytes_per_interval is initialized when checking
bandwidth utilization for SCSI layer blocking.
Co-developed-by: Justin Tee <justin.tee@broadcom.com>
Signed-off-by: Justin Tee <justin.tee@broadcom.com>
Signed-off-by: James Smart <jsmart2021@gmail.com>
---
drivers/scsi/lpfc/lpfc_scsi.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/lpfc/lpfc_scsi.c
index b70f71b5c1f7..a2cd22728b0f 100644
--- a/drivers/scsi/lpfc/lpfc_scsi.c
+++ b/drivers/scsi/lpfc/lpfc_scsi.c
@@ -3961,7 +3961,8 @@ lpfc_update_cmf_cmd(struct lpfc_hba *phba, uint32_t size)
int cpu;
/* At this point we are either LPFC_CFG_MANAGED or LPFC_CFG_MONITOR */
- if (phba->cmf_active_mode == LPFC_CFG_MANAGED) {
+ if (phba->cmf_active_mode == LPFC_CFG_MANAGED &&
+ phba->cmf_max_bytes_per_interval) {
total = 0;
for_each_present_cpu(cpu) {
cgs = per_cpu_ptr(phba->cmf_stat, cpu);
--
2.26.2
next prev parent reply other threads:[~2021-09-10 23:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-10 23:31 [PATCH 00/14] lpfc: Update lpfc to revision 14.0.0.2 James Smart
2021-09-10 23:31 ` [PATCH 01/14] lpfc: Fix list_add corruption in lpfc_drain_txq James Smart
2021-09-10 23:31 ` [PATCH 02/14] lpfc: Don't release final kref on Fport node while ABTS outstanding James Smart
2021-09-10 23:31 ` [PATCH 03/14] lpfc: Fix premature rpi release for unsolicited TPLS and LS_RJT James Smart
2021-09-10 23:31 ` [PATCH 04/14] lpfc: Fix hang on unload due to stuck fport node James Smart
2021-09-10 23:31 ` [PATCH 05/14] lpfc: Fix rediscovery of tape device after issue lip James Smart
2021-09-10 23:31 ` [PATCH 06/14] lpfc: Don't remove ndlp on PRLI errors in P2P mode James Smart
2021-09-10 23:31 ` [PATCH 07/14] lpfc: Fix NVME I/O failover to non-optimized path James Smart
2021-09-10 23:31 ` [PATCH 08/14] lpfc: Fix FCP I/O flush functionality for TMF routines James Smart
2021-09-10 23:31 ` [PATCH 09/14] lpfc: Fix EEH support for NVME I/O James Smart
2021-09-10 23:31 ` [PATCH 10/14] lpfc: Adjust bytes received vales during cmf timer interval James Smart
2021-09-10 23:31 ` James Smart [this message]
2021-09-10 23:31 ` [PATCH 12/14] lpfc: Zero CGN stats only during initial driver load and stat reset James Smart
2021-09-10 23:31 ` [PATCH 13/14] lpfc: Improve PBDE checks during SGL processing James Smart
2021-09-10 23:31 ` [PATCH 14/14] lpfc: Update lpfc version to 14.0.0.2 James Smart
2021-09-15 3:16 ` [PATCH 00/14] lpfc: Update lpfc to revision 14.0.0.2 Martin K. Petersen
2021-09-22 4:45 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210910233159.115896-12-jsmart2021@gmail.com \
--to=jsmart2021@gmail.com \
--cc=justin.tee@broadcom.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.