From: David Sterba <dsterba@suse.cz>
To: Nikolay Borisov <nborisov@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 4/5] btrfs: pull up qgroup checks from delayed-ref core to init time
Date: Mon, 11 Oct 2021 17:05:00 +0200 [thread overview]
Message-ID: <20211011150500.GP9286@twin.jikos.cz> (raw)
In-Reply-To: <20211011101019.1409855-5-nborisov@suse.com>
On Mon, Oct 11, 2021 at 01:10:18PM +0300, Nikolay Borisov wrote:
> @@ -279,6 +279,8 @@ static inline void btrfs_init_tree_ref(struct btrfs_ref *generic_ref,
> generic_ref->tree_ref.level = level;
> generic_ref->tree_ref.owning_root = root;
> generic_ref->type = BTRFS_REF_METADATA;
> + generic_ref->skip_qgroup = skip_qgroup || !(is_fstree(root) &&
> + (!mod_root || is_fstree(mod_root)));
Please avoid overly long conditions when assigning them as expression.
So far we've been doing only simple == or ?:, anything else should be
an if-else.
next prev parent reply other threads:[~2021-10-11 15:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-11 10:10 [PATCH 0/5] Make real_root used only in ref-verify Nikolay Borisov
2021-10-11 10:10 ` [PATCH 1/5] btrfs: Rename root fields in delayed refs structs Nikolay Borisov
2021-10-11 15:00 ` David Sterba
2021-10-11 10:10 ` [PATCH 2/5] btrfs: Rely on owning_root field in btrfs_add_delayed_tree_ref to detect CHUNK_ROOT Nikolay Borisov
2021-10-11 10:10 ` [PATCH 3/5] btrfs: Add additional parameters to btrfs_init_tree_ref/btrfs_init_data_ref Nikolay Borisov
2021-10-11 10:10 ` [PATCH 4/5] btrfs: pull up qgroup checks from delayed-ref core to init time Nikolay Borisov
2021-10-11 15:05 ` David Sterba [this message]
2021-10-11 10:10 ` [PATCH 5/5] btrfs: make real_root optional Nikolay Borisov
2021-10-11 15:05 ` David Sterba
2021-10-11 15:09 ` Nikolay Borisov
2021-10-11 15:08 ` [PATCH 0/5] Make real_root used only in ref-verify David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211011150500.GP9286@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.