From: Herbert Xu <herbert@gondor.apana.org.au>
To: Cai Huoqing <caihuoqing@baidu.com>
Cc: hch@infradead.org, caihuoqing@baidu.com, bbrezillon@kernel.org,
arno@natisbad.org, schalla@marvell.com, davem@davemloft.net,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] crypto: octeontx2 - Use dma_alloc_noncoherent() instead of kzalloc/dma_map_single()
Date: Fri, 22 Oct 2021 20:11:02 +0800 [thread overview]
Message-ID: <20211022121102.GA28240@gondor.apana.org.au> (raw)
In-Reply-To: <20211012032229.2307-1-caihuoqing@baidu.com>
Cai Huoqing <caihuoqing@baidu.com> wrote:
>
> @@ -1489,11 +1482,9 @@ int otx2_cpt_discover_eng_capabilities(struct otx2_cptpf_dev *cptpf)
>
> cptpf->eng_caps[etype].u = be64_to_cpup(rptr);
> }
> - dma_unmap_single(&pdev->dev, rptr_baddr, len, DMA_BIDIRECTIONAL);
> + dma_free_noncoherent(&pdev->dev, len, (void *)result, rptr_baddr, DMA_BIDIRECTIONAL);
Why the cast?
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2021-10-22 12:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-12 3:22 [PATCH v2] crypto: octeontx2 - Use dma_alloc_noncoherent() instead of kzalloc/dma_map_single() Cai Huoqing
2021-10-22 12:11 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211022121102.GA28240@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=arno@natisbad.org \
--cc=bbrezillon@kernel.org \
--cc=caihuoqing@baidu.com \
--cc=davem@davemloft.net \
--cc=hch@infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=schalla@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.