From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v3 2/2] mwifiex: Try waking the firmware until we get an interrupt
Date: Tue, 26 Oct 2021 10:44:45 +0800 [thread overview]
Message-ID: <202110261032.IOG6rHHb-lkp@intel.com> (raw)
In-Reply-To: <20211011133224.15561-3-verdre@v0yd.nl>
[-- Attachment #1: Type: text/plain, Size: 3697 bytes --]
Hi "Jonas,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on kvalo-wireless-drivers-next/master]
[also build test WARNING on v5.15-rc7]
[cannot apply to next-20211025]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Jonas-Dre-ler/mwifiex-Work-around-firmware-bugs-on-88W8897-chip/20211011-213355
base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master
config: arm64-defconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/e0e25bbda88f5c6c729414fb18ede64aa80d4032
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Jonas-Dre-ler/mwifiex-Work-around-firmware-bugs-on-88W8897-chip/20211011-213355
git checkout e0e25bbda88f5c6c729414fb18ede64aa80d4032
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
drivers/net/wireless/marvell/mwifiex/pcie.c: In function 'mwifiex_pm_wakeup_card':
>> drivers/net/wireless/marvell/mwifiex/pcie.c:659:13: warning: variable 'retval' set but not used [-Wunused-but-set-variable]
659 | int retval;
| ^~~~~~
vim +/retval +659 drivers/net/wireless/marvell/mwifiex/pcie.c
653
654 /* This function wakes up the card by reading fw_status register. */
655 static int mwifiex_pm_wakeup_card(struct mwifiex_adapter *adapter)
656 {
657 struct pcie_service_card *card = adapter->card;
658 const struct mwifiex_pcie_card_reg *reg = card->pcie.reg;
> 659 int retval;
660
661 mwifiex_dbg(adapter, EVENT,
662 "event: Wakeup device...\n");
663
664 if (reg->sleep_cookie)
665 mwifiex_pcie_dev_wakeup_delay(adapter);
666
667 /* The 88W8897 PCIe+USB firmware (latest version 15.68.19.p21) sometimes
668 * appears to ignore or miss our wakeup request, so we continue trying
669 * until we receive an interrupt from the card.
670 */
671 if (read_poll_timeout(mwifiex_write_reg, retval,
672 READ_ONCE(adapter->int_status) != 0,
673 500, 500 * N_WAKEUP_TRIES_SHORT_INTERVAL,
674 false,
675 adapter, reg->fw_status, FIRMWARE_READY_PCIE)) {
676 if (read_poll_timeout(mwifiex_write_reg, retval,
677 READ_ONCE(adapter->int_status) != 0,
678 10000, 10000 * N_WAKEUP_TRIES_LONG_INTERVAL,
679 false,
680 adapter, reg->fw_status, FIRMWARE_READY_PCIE)) {
681 mwifiex_dbg(adapter, ERROR,
682 "Firmware didn't wake up\n");
683 return -EIO;
684 }
685 }
686
687 if (reg->sleep_cookie) {
688 mwifiex_pcie_dev_wakeup_delay(adapter);
689 mwifiex_dbg(adapter, INFO,
690 "PCIE wakeup: Setting PS_STATE_AWAKE\n");
691 adapter->ps_state = PS_STATE_AWAKE;
692 }
693
694 return 0;
695 }
696
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 55810 bytes --]
prev parent reply other threads:[~2021-10-26 2:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-11 13:32 [PATCH v3 0/2] mwifiex: Work around firmware bugs on 88W8897 chip Jonas Dreßler
2021-10-11 13:32 ` [PATCH v3 1/2] mwifiex: Read a PCI register after writing the TX ring write pointer Jonas Dreßler
2021-10-18 12:30 ` Kalle Valo
2021-10-11 13:32 ` [PATCH v3 2/2] mwifiex: Try waking the firmware until we get an interrupt Jonas Dreßler
2021-10-26 2:44 ` kernel test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202110261032.IOG6rHHb-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.